Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2550343002: Move border-collapse to be generated in ComputedStyleBase (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
4 * reserved. 4 * reserved.
5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
835 m_nonInheritedData.m_overflowY != other.m_nonInheritedData.m_overflowY || 835 m_nonInheritedData.m_overflowY != other.m_nonInheritedData.m_overflowY ||
836 m_nonInheritedData.m_clear != other.m_nonInheritedData.m_clear || 836 m_nonInheritedData.m_clear != other.m_nonInheritedData.m_clear ||
837 m_nonInheritedData.m_unicodeBidi != 837 m_nonInheritedData.m_unicodeBidi !=
838 other.m_nonInheritedData.m_unicodeBidi || 838 other.m_nonInheritedData.m_unicodeBidi ||
839 floating() != other.floating() || 839 floating() != other.floating() ||
840 m_nonInheritedData.m_originalDisplay != 840 m_nonInheritedData.m_originalDisplay !=
841 other.m_nonInheritedData.m_originalDisplay) 841 other.m_nonInheritedData.m_originalDisplay)
842 return true; 842 return true;
843 843
844 if (isDisplayTableType(display())) { 844 if (isDisplayTableType(display())) {
845 if (m_inheritedData.m_borderCollapse != 845 if (borderCollapse() != other.borderCollapse() ||
846 other.m_inheritedData.m_borderCollapse ||
847 emptyCells() != other.emptyCells() || 846 emptyCells() != other.emptyCells() ||
848 captionSide() != other.captionSide() || 847 captionSide() != other.captionSide() ||
849 m_nonInheritedData.m_tableLayout != 848 m_nonInheritedData.m_tableLayout !=
850 other.m_nonInheritedData.m_tableLayout) 849 other.m_nonInheritedData.m_tableLayout)
851 return true; 850 return true;
852 851
853 // In the collapsing border model, 'hidden' suppresses other borders, while 852 // In the collapsing border model, 'hidden' suppresses other borders, while
854 // 'none' does not, so these style differences can be width differences. 853 // 'none' does not, so these style differences can be width differences.
855 if (m_inheritedData.m_borderCollapse && 854 if ((borderCollapse() == EBorderCollapse::Collapse) &&
alancutter (OOO until 2018) 2016/12/06 03:50:30 Pleased to see this change.
856 ((borderTopStyle() == BorderStyleHidden && 855 ((borderTopStyle() == BorderStyleHidden &&
857 other.borderTopStyle() == BorderStyleNone) || 856 other.borderTopStyle() == BorderStyleNone) ||
858 (borderTopStyle() == BorderStyleNone && 857 (borderTopStyle() == BorderStyleNone &&
859 other.borderTopStyle() == BorderStyleHidden) || 858 other.borderTopStyle() == BorderStyleHidden) ||
860 (borderBottomStyle() == BorderStyleHidden && 859 (borderBottomStyle() == BorderStyleHidden &&
861 other.borderBottomStyle() == BorderStyleNone) || 860 other.borderBottomStyle() == BorderStyleNone) ||
862 (borderBottomStyle() == BorderStyleNone && 861 (borderBottomStyle() == BorderStyleNone &&
863 other.borderBottomStyle() == BorderStyleHidden) || 862 other.borderBottomStyle() == BorderStyleHidden) ||
864 (borderLeftStyle() == BorderStyleHidden && 863 (borderLeftStyle() == BorderStyleHidden &&
865 other.borderLeftStyle() == BorderStyleNone) || 864 other.borderLeftStyle() == BorderStyleNone) ||
(...skipping 1605 matching lines...) Expand 10 before | Expand all | Expand 10 after
2471 if (value < 0) 2470 if (value < 0)
2472 fvalue -= 0.5f; 2471 fvalue -= 0.5f;
2473 else 2472 else
2474 fvalue += 0.5f; 2473 fvalue += 0.5f;
2475 } 2474 }
2476 2475
2477 return roundForImpreciseConversion<int>(fvalue / zoomFactor); 2476 return roundForImpreciseConversion<int>(fvalue / zoomFactor);
2478 } 2477 }
2479 2478
2480 } // namespace blink 2479 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698