Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2550313003: Made CSSPropertyAPIWillChange which implements API for will-change (Closed)

Created:
4 years ago by aazzam
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made CSSPropertyAPIWillChange which implements API for will-change Made implementation of CSSPropertyAPI for the will change property. The logic for this was taken out of CSSPropertyParser.cpp and moved into CSSPropertyAPIWillChange.cpp. Also fixed error in CSSPropertyDescriptor.cpp.tmpl which meant only one class could be implemented (missing comma in array). BUG=668012 Committed: https://crrev.com/427ea09a9ba5cd3cce269836798ec1bd6cff0412 Cr-Commit-Position: refs/heads/master@{#439387}

Patch Set 1 #

Total comments: 1

Patch Set 2 : reordered #

Patch Set 3 : rebase #

Patch Set 4 : changed upstream #

Patch Set 5 : rebased #

Patch Set 6 : changed flags #

Patch Set 7 : rebase #

Patch Set 8 : format #

Patch Set 9 : Fixed bug with CSSPropertyDescriptor.cpp.tmpl #

Patch Set 10 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -55 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -53 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWillChange.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +66 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
aazzam
4 years ago (2016-12-07 03:02:20 UTC) #2
sashab
Eeeek this is so exciting!! Nice work anna!! :D Just one small comment https://codereview.chromium.org/2550313003/diff/1/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.cpp File ...
4 years ago (2016-12-07 03:12:18 UTC) #3
aazzam
PTAL :)
4 years ago (2016-12-07 04:37:47 UTC) #4
aazzam
Rebase, PTAL :)
4 years ago (2016-12-15 23:32:45 UTC) #6
sashab
lgtm
4 years ago (2016-12-15 23:49:20 UTC) #7
sashab
Wrap CL desc to 72 chars :)
4 years ago (2016-12-15 23:49:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550313003/180001
4 years ago (2016-12-18 22:02:14 UTC) #11
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years ago (2016-12-19 00:15:11 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-19 00:17:30 UTC) #16
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/427ea09a9ba5cd3cce269836798ec1bd6cff0412
Cr-Commit-Position: refs/heads/master@{#439387}

Powered by Google App Engine
This is Rietveld 408576698