Issue 2550203002: Options: lazily load Polymer when quick unlock dialog is triggered

Issue 2550203002: Options: lazily load Polymer when quick unlock dialog is triggered (Closed)

Created:
4 years ago by jdufault

Modified:
4 years ago

Reviewers:
jdufault, xiaoyinh(OOO Sep 11-29)

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Options: lazily load Polymer when quick unlock dialog is triggered Ruthlessly borrowed from https://codereview.chromium.org/2547273002/ by Jacob Dufault <jdufault@chromium.org>; and simplified :). From that CL's description: Locally, this brings first paint time from 1000ms to 500ms. R=jdufault@chromium.org,xiaoyinh@chromium.org BUG=670914 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2529293015 Cr-Commit-Position: refs/heads/master@{#436159} (cherry picked from commit 71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9) Committed: https://chromium.googlesource.com/chromium/src/+/86b19c3786427aacb452bf52ea52832e3d98bd70

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js	View		2 chunks	+23 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/options/options.html	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

jdufault

4 years ago (2016-12-05 18:27:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
86b19c3786427aacb452bf52ea52832e3d98bd70.