Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2529293015: Options: lazily load Polymer when quick unlock dialog is triggered (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Options: lazily load Polymer when quick unlock dialog is triggered Ruthlessly borrowed from https://codereview.chromium.org/2547273002/ by Jacob Dufault <jdufault@chromium.org>; and simplified :). From that CL's description: Locally, this brings first paint time from 1000ms to 500ms. R=jdufault@chromium.org,xiaoyinh@chromium.org BUG=670914 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9 Cr-Commit-Position: refs/heads/master@{#436159}

Patch Set 1 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js View 2 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
4 years ago (2016-12-03 02:06:08 UTC) #4
jdufault
lgtm, I'd prefer we preload on idle but I understand the argument for not doing ...
4 years ago (2016-12-03 02:16:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529293015/40001
4 years ago (2016-12-03 02:19:05 UTC) #10
xiaoyinh(OOO Sep 11-29)
Thanks for the CL. lgtm.
4 years ago (2016-12-03 02:20:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-03 03:35:06 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-03 03:38:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9
Cr-Commit-Position: refs/heads/master@{#436159}

Powered by Google App Engine
This is Rietveld 408576698