Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html

Issue 2550063002: Remove double constructors that assume degrees from CSSRotation (Closed)
Patch Set: Fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html
diff --git a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html
index e9bcd92182a4d72593bbadcd32baaa025b824a3c..49ed32c02d0a2603d1054aa49febc8573465a593 100644
--- a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html
+++ b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html
@@ -3,12 +3,11 @@
<script src="../../resources/testharnessreport.js"></script>
<div id="testElement"></div>
-<div id="crashTest" style="transform:translateY(50px)"></div>
<script>
test(function() {
- var transform = new CSSTransformValue([new CSSRotation(20)]);
+ var transform = new CSSTransformValue([new CSSRotation(new CSSAngleValue(20, 'deg'))]);
assert_equals(testElement.styleMap.get('transform'), null);
@@ -17,14 +16,15 @@ test(function() {
}, "Setting transform works on a regular element.");
test(function() {
- var transform = new CSSTransformValue([new CSSRotation(30)]);
+ var transform = new CSSTransformValue([new CSSRotation(new CSSAngleValue(30, 'deg'))]);
testElement.styleMap.set('transform', transform);
assert_equals(testElement.styleMap.get('transform').cssText, 'rotate(30deg)');
}, "Getting transform works on a regular element.");
test(function() {
- crashTest.styleMap.entries();
+ testElement.style.transform = 'translateY(50px)';
+ testElement.styleMap.entries();
}, "Unhandled case doesn't crash.");
</script>

Powered by Google App Engine
This is Rietveld 408576698