Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html

Issue 2550063002: Remove double constructors that assume degrees from CSSRotation (Closed)
Patch Set: Fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html
diff --git a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html
index ba654ee8485cbbf1280a4e67ee4f9b0d02c97ba0..08c65b439cf6295d74458709d7302d19a520cca4 100644
--- a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html
+++ b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html
@@ -18,57 +18,13 @@ function validateTransformWithSingleRotation(transform, x, y, z, angle, cssText)
assert_true(components[0] instanceof CSSRotation);
assert_equals(components[0].cssText, cssText);
- assert_approx_equals(components[0].angle, angle, EPSILON);
+ assert_approx_equals(components[0].angle.degrees, angle, EPSILON);
assert_approx_equals(components[0].x, x, EPSILON);
assert_approx_equals(components[0].y, y, EPSILON);
assert_approx_equals(components[0].z, z, EPSILON);
}
test(function() {
- testElement.style.transform = "rotate(30deg)";
-
- validateTransformWithSingleRotation(
- testElement.styleMap.get("transform"),
- 0, 0, 1, 30,
- "rotate(30deg)");
-}, "Simple rotation read from a StyleMap is correct");
-
-test(function() {
- testElement.style.transform = "rotate(10rad)";
-
- validateTransformWithSingleRotation(
- testElement.styleMap.get("transform"),
- 0, 0, 1, 572.957795,
- "rotate(572.958deg)");
-}, "Simple rotation using radians read from a StyleMap is correct");
-
-test(function() {
- testElement.style.transform = "rotate(20grad)";
-
- validateTransformWithSingleRotation(
- testElement.styleMap.get("transform"),
- 0, 0, 1, 18,
- "rotate(18deg)");
-}, "Simple rotation using gradians read from a StyleMap is correct");
-
-test(function() {
- testElement.style.transform = "rotate(0.5turn)";
-
- validateTransformWithSingleRotation(
- testElement.styleMap.get("transform"),
- 0, 0, 1, 180,
- "rotate(180deg)");
-}, "Simple rotation using turns read from a StyleMap is correct");
-
-test(function() {
- testElement.style.transform = "rotate3d(1, 2, 3, 30deg)";
- validateTransformWithSingleRotation(
- testElement.styleMap.get("transform"),
- 1, 2, 3, 30,
- "rotate3d(1, 2, 3, 30deg)");
-}, "rotate3d read from a StyleMap is correct");
-
-test(function() {
testElement.style.transform = "rotateX(45deg)";
validateTransformWithSingleRotation(
testElement.styleMap.get("transform"),
@@ -81,7 +37,7 @@ test(function() {
validateTransformWithSingleRotation(
testElement.styleMap.get("transform"),
1, 0, 0, 57.29578,
- "rotate3d(1, 0, 0, 57.2958deg)");
+ "rotate3d(1, 0, 0, 1rad)");
}, "rotateX with units other than degrees");
test(function() {
@@ -97,7 +53,7 @@ test(function() {
validateTransformWithSingleRotation(
testElement.styleMap.get("transform"),
0, 1, 0, 1.8,
- "rotate3d(0, 1, 0, 1.8deg)");
+ "rotate3d(0, 1, 0, 2grad)");
}, "rotateY with units other than degrees");
test(function() {
@@ -113,7 +69,7 @@ test(function() {
validateTransformWithSingleRotation(
testElement.styleMap.get("transform"),
0, 0, 1, 360,
- "rotate3d(0, 0, 1, 360deg)");
+ "rotate3d(0, 0, 1, 1turn)");
}, "rotateZ with units other than degrees");
</script>

Powered by Google App Engine
This is Rietveld 408576698