Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.cc

Issue 254983006: Fix: Adding list of supported codecs for MP4 containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing extended codecs tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/renderer_webkitplatformsupport_impl.cc
diff --git a/content/renderer/renderer_webkitplatformsupport_impl.cc b/content/renderer/renderer_webkitplatformsupport_impl.cc
index aa46b53274bfdfdc3fef003131d785c03078ebe1..61c456b7992d5f7a4c7a8c9c80d7caeecd3f5c1e 100644
--- a/content/renderer/renderer_webkitplatformsupport_impl.cc
+++ b/content/renderer/renderer_webkitplatformsupport_impl.cc
@@ -438,6 +438,14 @@ RendererWebKitPlatformSupportImpl::MimeRegistry::supportsMediaMIMEType(
if (net::IsSupportedStrictMediaMimeType(mime_type_ascii, strict_codecs))
return IsSupported;
+ // Codecs required by MP4 and HLS mime types have a profile paramter in them
+ // Since we do not check the exact profile version supported by the system,
+ // we only return a "maybe" if the codecs are RFC6381 compliant.
+ if (net::IsSupportedStrictMP4OrHLSMediaMimeType(mime_type_ascii,
acolwell GONE FROM CHROMIUM 2014/05/12 14:54:18 I don't think MP4OrHLS should be in the method nam
amogh.bihani 2014/05/15 09:05:53 Done.
+ strict_codecs)) {
+ return MayBeSupported;
+ }
+
// We support the container, but no codecs were specified.
if (codecs.isNull())
return MayBeSupported;

Powered by Google App Engine
This is Rietveld 408576698