Fix: Adding list of supported codecs for MP4 containers

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/memory/shared_memory.h"
@@ skipping 420 matching lines @@
   }
 
   // Check list of strict codecs to see if it is supported.
   if (net::IsStrictMediaMimeType(mime_type_ascii)) {
     // Check if the codecs are a perfect match.
     std::vector<std::string> strict_codecs;
     net::ParseCodecString(ToASCIIOrEmpty(codecs), &strict_codecs, false);
     if (net::IsSupportedStrictMediaMimeType(mime_type_ascii, strict_codecs))
       return IsSupported;
 
+    // Codecs required by MP4 and HLS mime types have a profile paramter in them
+    // Since we do not check the exact profile version supported by the system,
+    // we only return a "maybe" if the codecs are RFC6381 compliant.
+    if (net::IsSupportedStrictMP4OrHLSMediaMimeType(mime_type_ascii,

[acolwell GONE FROM CHROMIUM, 2014/05/12 14:54:18]

I don't think MP4OrHLS should be in the method name. It seems to me that
IsSupportedStrictMediaMimeType() should be changed to return an enum that
includes a MayBe or this method is be something like
MayBeSupportedStrictMediaMimeType() since really you are just trying to capture
the MayBe situations. My preference is the former solution since I don't really
see the point of having 2 methods here.

[amogh.bihani, 2014/05/15 09:05:53]

Done.

+                                                    strict_codecs)) {
+      return MayBeSupported;
+    }
+
     // We support the container, but no codecs were specified.
     if (codecs.isNull())
       return MayBeSupported;
 
     return IsNotSupported;
   }
 
   // If we don't recognize the codec, it's possible we support it.
   std::vector<std::string> parsed_codecs;
   net::ParseCodecString(ToASCIIOrEmpty(codecs), &parsed_codecs, true);
@@ skipping 720 matching lines @@
     return;
   QuotaDispatcher::ThreadSpecificInstance(
       thread_safe_sender_.get(),
       quota_message_filter_.get())->QueryStorageUsageAndQuota(
           storage_partition,
           static_cast<quota::StorageType>(type),
           QuotaDispatcher::CreateWebStorageQuotaCallbacksWrapper(callbacks));
 }
 
 }  // namespace content