Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: net/base/mime_util_unittest.cc

Issue 254983006: Fix: Adding list of supported codecs for MP4 containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/mime_util.cc ('K') | « net/base/mime_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mime_util_unittest.cc
diff --git a/net/base/mime_util_unittest.cc b/net/base/mime_util_unittest.cc
index 61719889034a7ea3c7610f836063b082d23c16e7..ef2d9d725d6334855939fa1072d2d3988d5ce39f 100644
--- a/net/base/mime_util_unittest.cc
+++ b/net/base/mime_util_unittest.cc
@@ -113,15 +113,13 @@ TEST(MimeUtilTest, StrictMediaMimeType) {
EXPECT_TRUE(IsStrictMediaMimeType("audio/mp3"));
EXPECT_TRUE(IsStrictMediaMimeType("audio/x-mp3"));
- // TODO(amogh.bihani): These will be fixed http://crbug.com/53193
- EXPECT_FALSE(IsStrictMediaMimeType("video/mp4"));
- EXPECT_FALSE(IsStrictMediaMimeType("video/x-m4v"));
- EXPECT_FALSE(IsStrictMediaMimeType("audio/mp4"));
- EXPECT_FALSE(IsStrictMediaMimeType("audio/x-m4a"));
-
- EXPECT_FALSE(IsStrictMediaMimeType("application/x-mpegurl"));
- EXPECT_FALSE(IsStrictMediaMimeType("application/vnd.apple.mpegurl"));
- // ---------------------------------------------------------------------------
+ EXPECT_TRUE(IsStrictMediaMimeType("video/mp4"));
+ EXPECT_TRUE(IsStrictMediaMimeType("video/x-m4v"));
+ EXPECT_TRUE(IsStrictMediaMimeType("audio/mp4"));
+ EXPECT_TRUE(IsStrictMediaMimeType("audio/x-m4a"));
+
+ EXPECT_TRUE(IsStrictMediaMimeType("application/x-mpegurl"));
acolwell GONE FROM CHROMIUM 2014/05/22 20:21:42 I would expect these to be only true for Android.
amogh.bihani 2014/05/23 10:57:29 Yes HLS is supported only on Android, but that wou
+ EXPECT_TRUE(IsStrictMediaMimeType("application/vnd.apple.mpegurl"));
EXPECT_FALSE(IsStrictMediaMimeType("video/unknown"));
EXPECT_FALSE(IsStrictMediaMimeType("audio/unknown"));
« net/base/mime_util.cc ('K') | « net/base/mime_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698