Fix: Adding list of supported codecs for MP4 containers

net/base/mime_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "net/base/mime_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 95 matching lines @@
   EXPECT_TRUE(IsStrictMediaMimeType("audio/x-wav"));
 
   EXPECT_TRUE(IsStrictMediaMimeType("video/ogg"));
   EXPECT_TRUE(IsStrictMediaMimeType("audio/ogg"));
   EXPECT_TRUE(IsStrictMediaMimeType("application/ogg"));
 
   EXPECT_TRUE(IsStrictMediaMimeType("audio/mpeg"));
   EXPECT_TRUE(IsStrictMediaMimeType("audio/mp3"));
   EXPECT_TRUE(IsStrictMediaMimeType("audio/x-mp3"));
 
-  // TODO(amogh.bihani): These will be fixed http://crbug.com/53193
-  EXPECT_FALSE(IsStrictMediaMimeType("video/mp4"));
-  EXPECT_FALSE(IsStrictMediaMimeType("video/x-m4v"));
-  EXPECT_FALSE(IsStrictMediaMimeType("audio/mp4"));
-  EXPECT_FALSE(IsStrictMediaMimeType("audio/x-m4a"));
+  EXPECT_TRUE(IsStrictMediaMimeType("video/mp4"));
+  EXPECT_TRUE(IsStrictMediaMimeType("video/x-m4v"));
+  EXPECT_TRUE(IsStrictMediaMimeType("audio/mp4"));
+  EXPECT_TRUE(IsStrictMediaMimeType("audio/x-m4a"));
 
-  EXPECT_FALSE(IsStrictMediaMimeType("application/x-mpegurl"));
-  EXPECT_FALSE(IsStrictMediaMimeType("application/vnd.apple.mpegurl"));
-  // ---------------------------------------------------------------------------
+  EXPECT_TRUE(IsStrictMediaMimeType("application/x-mpegurl"));

[acolwell GONE FROM CHROMIUM, 2014/05/22 20:21:42]

I would expect these to be only true for Android. We don't support HLS on
desktop Chrome.

[amogh.bihani, 2014/05/23 10:57:29]

Yes HLS is supported only on Android, but that would be true from the complete
browser's perspective. In browser we first check whether the mime_type is
supported or not[1] and then move forward. This method comes after the check,
hence we do not put #ifdef in its list. Since all the mime types are available
in the list, this unittest is supposed to pass on all the platforms. (You may
notice that in this test, video/ogg is passing, even for android, because of
this reason.)
However, the media_canplaytype_browsertest should fail (and it does). In this
all the HLS tests return "" for canPlayType() query for non android platforms
(line 765-768 in that file of this patchset).

-------
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...

+  EXPECT_TRUE(IsStrictMediaMimeType("application/vnd.apple.mpegurl"));
 
   EXPECT_FALSE(IsStrictMediaMimeType("video/unknown"));
   EXPECT_FALSE(IsStrictMediaMimeType("audio/unknown"));
   EXPECT_FALSE(IsStrictMediaMimeType("application/unknown"));
   EXPECT_FALSE(IsStrictMediaMimeType("unknown/unknown"));
 }
 
 TEST(MimeUtilTest, MatchesMimeType) {
   EXPECT_TRUE(MatchesMimeType("*", "video/x-mpeg"));
   EXPECT_TRUE(MatchesMimeType("video/*", "video/x-mpeg"));
@@ skipping 275 matching lines @@
   std::string post_data;
   AddMultipartValueForUpload("value name", "value", "boundary",
                              "content type", &post_data);
   AddMultipartValueForUpload("value name", "value", "boundary",
                              "", &post_data);
   AddMultipartFinalDelimiterForUpload("boundary", &post_data);
   EXPECT_STREQ(ref_output, post_data.c_str());
 }
 
 }  // namespace net