src/runtime/runtime-regexp.cc - Issue 2549773002: Internalize strings in-place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-regexp.cc

Issue 2549773002: Internalize strings in-place (Closed)

Patch Set: forgot one Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-regexp.cc

diff --git a/src/runtime/runtime-regexp.cc b/src/runtime/runtime-regexp.cc

index 8b7578b667cb38cb1ae1cf4f883f03e3fa09d8fe..fd2826e471cfce695fa2a24e08d690b66e8277df 100644

--- a/src/runtime/runtime-regexp.cc

+++ b/src/runtime/runtime-regexp.cc

@@ -431,6 +431,9 @@ MUST_USE_RESULT static Object* StringReplaceGlobalAtomRegExpWithString(

} else {

result_len = static_cast<int>(result_len_64);

}

+ if (result_len == 0) {

+ return isolate->heap()->empty_string();

+ }

int subject_pos = 0;

int result_pos = 0;