Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: src/objects-debug.cc

Issue 2549773002: Internalize strings in-place (Closed)
Patch Set: forgot one Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 51969c5697204230eb06decd9afe8a9b559bcccc..e2eb9e6dc440b21bfde2ed1aa12241861d5d50a5 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -563,9 +563,10 @@ void ConsString::ConsStringVerify() {
CHECK(this->length() >= ConsString::kMinLength);
CHECK(this->length() == this->first()->length() + this->second()->length());
if (this->IsFlat()) {
- // A flat cons can only be created by String::SlowTryFlatten.
- // Afterwards, the first part may be externalized.
- CHECK(this->first()->IsSeqString() || this->first()->IsExternalString());
+ // A flat cons can only be created by String::SlowFlatten.
+ // Afterwards, the first part may be externalized or internalized.
+ CHECK(this->first()->IsSeqString() || this->first()->IsExternalString() ||
+ this->first()->IsThinString());
}
}
« src/objects.cc ('K') | « src/objects-body-descriptors-inl.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698