Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25497002: Generate toCSSFooValue() for CSS child values (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, haraken, do-not-use
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate toCSSFooValue() for CSS child values This cl adds toCSSFooValue() for CSSPrimitiveValue, CSSFilterValue, CSSLineBoxContainValue, CSSArrayFunctionValue, CSSTransformValue and CSSMixFunctionValue. And, this cl removes some unnecessary local variables. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -48 lines) Patch
M Source/bindings/v8/custom/V8CSSValueCustom.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSArrayFunctionValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSFilterValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSLineBoxContainValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSMixFunctionValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 chunk +1 line, -14 lines 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/css/CSSTransformValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 2 months ago (2013-10-01 11:32:02 UTC) #1
tkent
lgtm. This requires Source/bindings/ owner approval.
7 years, 2 months ago (2013-10-01 12:42:23 UTC) #2
haraken
bindings/ LGTM
7 years, 2 months ago (2013-10-01 12:43:17 UTC) #3
gyuyoung-inactive
On 2013/10/01 12:43:17, haraken wrote: > bindings/ LGTM Chris, how about you ?
7 years, 2 months ago (2013-10-02 07:42:48 UTC) #4
tkent
haraken's lgtm is enough. cq+.
7 years, 2 months ago (2013-10-02 08:42:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25497002/1
7 years, 2 months ago (2013-10-02 08:42:45 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7878
7 years, 2 months ago (2013-10-02 08:58:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25497002/1
7 years, 2 months ago (2013-10-02 09:08:32 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7882
7 years, 2 months ago (2013-10-02 09:24:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25497002/1
7 years, 2 months ago (2013-10-02 20:31:31 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8335
7 years, 2 months ago (2013-10-02 23:46:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25497002/1
7 years, 2 months ago (2013-10-03 00:51:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/25497002/1
7 years, 2 months ago (2013-10-03 05:40:30 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 10:27:28 UTC) #14
Message was sent while issue was closed. 
Change committed as 158798

Powered by Google App Engine
This is Rietveld 408576698