Source/core/css/resolver/StyleBuilderCustom.h - Issue 25497002: Generate toCSSFooValue() for CSS child values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.h

Issue 25497002: Generate toCSSFooValue() for CSS child values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleBuilderCustom.h

diff --git a/Source/core/css/resolver/StyleBuilderCustom.h b/Source/core/css/resolver/StyleBuilderCustom.h

index 597c5019b2525b85b226c5221e34936819992534..6fd471001cb0967e59841df1a2247c30c7f0930d 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.h

+++ b/Source/core/css/resolver/StyleBuilderCustom.h

@@ -53,9 +53,8 @@ public:

template <typename T>

T StyleBuilderConverter::convertComputedLength(StyleResolverState& state, CSSValue* value)

{

- CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

float zoom = state.style()->effectiveZoom();

- return primitiveValue->computeLength<T>(state.style(), state.rootElementStyle(), zoom);

+ return toCSSPrimitiveValue(value)->computeLength<T>(state.style(), state.rootElementStyle(), zoom);

}

template <typename T>