Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceObserver.h

Issue 2549673004: Remove RefPtr<ScriptState> from PerformanceObserver (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceObserver.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceObserver.h b/third_party/WebKit/Source/core/timing/PerformanceObserver.h
index 12190626096effb29f5adb3cd81c03a56e15bb84..cea36e179ba9dedf6f64bd4d44e2bc1cfe90bf11 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceObserver.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceObserver.h
@@ -13,12 +13,12 @@
namespace blink {
+class ExecutionContext;
class ExceptionState;
class PerformanceBase;
class PerformanceObserver;
class PerformanceObserverCallback;
class PerformanceObserverInit;
-class ScriptState;
using PerformanceEntryVector = HeapVector<Member<PerformanceEntry>>;
@@ -31,7 +31,7 @@ class CORE_EXPORT PerformanceObserver final
friend class PerformanceObserverTest;
public:
- static PerformanceObserver* create(ScriptState*,
+ static PerformanceObserver* create(ExecutionContext*,
PerformanceBase*,
PerformanceObserverCallback*);
static void resumeSuspendedObservers();
@@ -45,13 +45,13 @@ class CORE_EXPORT PerformanceObserver final
DECLARE_TRACE_WRAPPERS();
private:
- PerformanceObserver(ScriptState*,
+ PerformanceObserver(ExecutionContext*,
PerformanceBase*,
PerformanceObserverCallback*);
void deliver();
bool shouldBeSuspended() const;
- RefPtr<ScriptState> m_scriptState;
+ Member<ExecutionContext> m_executionContext;
TraceWrapperMember<PerformanceObserverCallback> m_callback;
WeakMember<PerformanceBase> m_performance;
PerformanceEntryVector m_performanceEntries;

Powered by Google App Engine
This is Rietveld 408576698