chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc - Issue 2549623006: Fix TestBrowserThread destruction order in CrOS tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc

Issue 2549623006: Fix TestBrowserThread destruction order in CrOS tests. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc ('k') | chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc

diff --git a/chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc b/chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc

index a77369a9881c1155687b160e46136fb4817d5a6f..66434cd554b6e85cbd095bc989b4097e0cae68b5 100644

--- a/chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc

+++ b/chrome/browser/metrics/leak_detector/leak_detector_controller_unittest.cc

@@ -59,7 +59,7 @@ class LeakDetectorControllerTest : public ::testing::Test {

// LeakDetector.

// See src/components/metrics/leak_detector/leak_detector.h for more info.

-base::LazyInstance<TestLeakDetectorController> g_instance =

+base::LazyInstance<TestLeakDetectorController>::Leaky g_instance =

gab 2016/12/02 19:23:51 Needs to be leaky or its destructor runs after the

oshima 2016/12/02 20:18:12 can you update the comment above?

gab 2016/12/03 03:02:27 Done.

LAZY_INSTANCE_INITIALIZER;

TEST_F(LeakDetectorControllerTest, SingleReport) {