Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc

Issue 2549623006: Fix TestBrowserThread destruction order in CrOS tests. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc
diff --git a/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc b/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc
index 09b38929e879da4de1d442c71ef11f0d94e97bd9..363101355c2b4bf0a21943be38ccbf4069ed572a 100644
--- a/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc
+++ b/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc
@@ -296,14 +296,16 @@ class EasyUnlockServiceTest : public testing::Test {
account_id.GetUserEmail());
}
+ private:
+ // Must outlive TestingProfiles.
+ content::TestBrowserThreadBundle thread_bundle_;
+
protected:
std::unique_ptr<TestingProfile> profile_;
std::unique_ptr<TestingProfile> secondary_profile_;
chromeos::MockUserManager* mock_user_manager_;
private:
- content::TestBrowserThreadBundle thread_bundle_;
-
chromeos::ScopedUserManagerEnabler scoped_user_manager_;
FakePowerManagerClient* power_manager_client_;

Powered by Google App Engine
This is Rietveld 408576698