Issue 2549623005: Merge to M56 to resolve crbug.com/668299 (ios bot breaks)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2549623005: Merge to M56 to resolve crbug.com/668299 (ios bot breaks) (Closed)

Created:
4 years ago by Sorin Jianu

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Merge to M56 to resolve crbug.com/668299 (ios bot breaks) updater_state_unittests: don't lookup a nil map on non-Windows platforms. UpdaterState::GetState returns nullptr, if the current platform is not Windows, and then the test calls at() method on the returned map. This fixes LTO Linux bot: https://build.chromium.org/p/chromium.fyi/builders/LTO%20Linux/builds/1560 BUG=615187 Review-Url: https://codereview.chromium.org/2536723004 Cr-Commit-Position: refs/heads/master@{#434845} (cherry picked from commit 325a49517707810d1abdfb0040e19b7abb5addbe) Committed: https://chromium.googlesource.com/chromium/src/+/4322e58aff6ec6908f38ebb52e19fce74251c7de

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	components/update_client/updater_state_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Sorin Jianu

4 years ago (2016-12-02 18:53:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4322e58aff6ec6908f38ebb52e19fce74251c7de.