Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2536723004: updater_state_unittests: don't lookup a nil map on non-Windows platforms. (Closed)

Created:
4 years ago by krasin1
Modified:
4 years ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

updater_state_unittests: don't lookup a nil map on non-Windows platforms. UpdaterState::GetState returns nullptr, if the current platform is not Windows, and then the test calls at() method on the returned map. This fixes LTO Linux bot: https://build.chromium.org/p/chromium.fyi/builders/LTO%20Linux/builds/1560 BUG=615187 Committed: https://crrev.com/325a49517707810d1abdfb0040e19b7abb5addbe Cr-Commit-Position: refs/heads/master@{#434845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/update_client/updater_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
krasin1
4 years ago (2016-11-29 00:24:33 UTC) #2
Sorin Jianu
Thank you!
4 years ago (2016-11-29 00:40:03 UTC) #6
krasin1
On 2016/11/29 00:40:03, Sorin Jianu wrote: > Thank you! Hi Sorin, may I have your ...
4 years ago (2016-11-29 01:32:01 UTC) #7
Sorin Jianu
lgtm
4 years ago (2016-11-29 01:34:58 UTC) #8
krasin1
On 2016/11/29 01:34:58, Sorin Jianu wrote: > lgtm Thank you, Sorin!
4 years ago (2016-11-29 01:37:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536723004/1
4 years ago (2016-11-29 01:41:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:51:54 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-29 02:53:38 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/325a49517707810d1abdfb0040e19b7abb5addbe
Cr-Commit-Position: refs/heads/master@{#434845}

Powered by Google App Engine
This is Rietveld 408576698