Replace SizingFlags in layouts with ViewportMode

Replace SizingFlags in layouts with ViewportMode

This change replaces the concept of sizing flags, which control both
viewport size and browser controls behavior, with mutually exclusive
modes:

- ALWAYS_FULLSCREEN
- ALWAYS_SHOWING_BROWSER_CONTROLS
- DYNAMIC_BROWSER_CONTROLS
- USE_PREVIOUS_BROWSER_CONTROLS_STATE

Permanent android browser controls state can be changed by overriding
two functions in the layout class:

- forceShowBrowserControlsAndroidView()
- forceHideBrowserControlsAndroidView()

These modes and functions reduce the amount of research that needs to
be done to understand how a particular layout is going to behave.

BUG=670459
Committed: https://crrev.com/1a3dfa323fd2fc5f5afa2fe102556029a26f24bc
Cr-Commit-Position: refs/heads/master@{#437419}

[mdjones, 2016-12-01 22:05:23]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mdjones, 2016-12-01 22:05:23]

ptal

[mdjones, 2016-12-01 22:06:01]

https://codereview.chromium.org/2549503004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java
(right):

https://codereview.chromium.org/2549503004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java:57:
public enum ViewportMode {
Should these be ints?

[David Trainor- moved to gerrit, 2016-12-08 23:54:54]

lgtm thanks!

[mdjones, 2016-12-09 00:17:08]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-12-09 00:17:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:42:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481242628146810,
"parent_rev": "9b5697018f5308d7661710b163c0ae4fc875f27a", "commit_rev":
"25c5ba61e0c758d18cdab1bc59428ebe0ed10cab"}

[commit-bot: I haz the power, 2016-12-09 01:43:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-09 01:45:45]

Description was changed from

==========
Replace SizingFlags in layouts with ViewportMode

This change replaces the concept of sizing flags, which control both
viewport size and browser controls behavior, with mutually exclusive
modes:

- ALWAYS_FULLSCREEN
- ALWAYS_SHOWING_BROWSER_CONTROLS
- DYNAMIC_BROWSER_CONTROLS
- USE_PREVIOUS_BROWSER_CONTROLS_STATE

Permanent android browser controls state can be changed by overriding
two functions in the layout class:

- forceShowBrowserControlsAndroidView()
- forceHideBrowserControlsAndroidView()

These modes and functions reduce the amount of research that needs to
be done to understand how a particular layout is going to behave.

BUG=670459
==========

to

==========
Replace SizingFlags in layouts with ViewportMode

This change replaces the concept of sizing flags, which control both
viewport size and browser controls behavior, with mutually exclusive
modes:

- ALWAYS_FULLSCREEN
- ALWAYS_SHOWING_BROWSER_CONTROLS
- DYNAMIC_BROWSER_CONTROLS
- USE_PREVIOUS_BROWSER_CONTROLS_STATE

Permanent android browser controls state can be changed by overriding
two functions in the layout class:

- forceShowBrowserControlsAndroidView()
- forceHideBrowserControlsAndroidView()

These modes and functions reduce the amount of research that needs to
be done to understand how a particular layout is going to behave.

BUG=670459

Committed: https://crrev.com/1a3dfa323fd2fc5f5afa2fe102556029a26f24bc
Cr-Commit-Position: refs/heads/master@{#437419}
==========

[commit-bot: I haz the power, 2016-12-09 01:45:46]

Patchset 3 (id:??) landed as
https://crrev.com/1a3dfa323fd2fc5f5afa2fe102556029a26f24bc
Cr-Commit-Position: refs/heads/master@{#437419}