Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

Issue 2549503004: Replace SizingFlags in layouts with ViewportMode (Closed)
Patch Set: use proper toolbar control Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java
index 4d03c47f65d8020223e4a3cb7d4e76c930655448..f719843353e86f5f3ad1d40f42464c674e408232 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java
@@ -98,9 +98,20 @@ public class ToolbarSwipeLayout extends Layout implements Animatable<ToolbarSwip
}
@Override
- public int getSizingFlags() {
- return mMoveToolbar ? SizingFlags.HELPER_HIDE_TOOLBAR_IMMEDIATE
- : SizingFlags.HELPER_NO_FULLSCREEN_SUPPORT;
+ public ViewportMode getViewportMode() {
+ // This seems counter-intuitive, but if the toolbar moves the android view is not showing.
+ // That means the compositor has to draw it and therefore needs the fullscreen viewport.
+ // Likewise, when the android view is showing, the compositor controls do not draw and the
+ // content needs to pretend it does to draw correctly.
+ // TODO(mdjones): Remove toolbar_impact_height from tab_layer.cc so this makes more sense.
+ return mMoveToolbar ? ViewportMode.ALWAYS_FULLSCREEN
+ : ViewportMode.ALWAYS_SHOWING_BROWSER_CONTROLS;
+ }
+
+ @Override
+ public boolean forceHideBrowserControlsAndroidView() {
+ // If the toolbar moves, the android browser controls need to be hidden.
+ return super.forceHideBrowserControlsAndroidView() || mMoveToolbar;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698