Rename PlatformScreen to ScreenManager.

Rename PlatformScreen to ScreenManager.

ScreenManager is more descriptive and is what I've been using in design
docs. Simple update of file and class names.

BUG=none

Committed: https://crrev.com/888325bb4c98cc45b4f5003980918904c7d384d5
Cr-Commit-Position: refs/heads/master@{#435735}

[kylechar, 2016-12-01 14:56:54]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org

[kylechar, 2016-12-01 14:56:54]

+msw for services/ui/ws/*
+rjkroege FYI

[rjkroege, 2016-12-01 18:17:50]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-12-01 18:17:50]

fwiw: lgtm

[msw, 2016-12-01 20:01:19]

lgtm with nits

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/display_mana...
File services/ui/ws/display_manager.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/display_mana...
services/ui/ws/display_manager.cc:11: #include
"services/ui/display/screen_manager.h"
nit: needed?

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/test_utils.h
File services/ui/ws/test_utils.h (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/test_utils.h...
services/ui/ws/test_utils.h:44: // Test PlatformDisplay instance that allows
adding/modifying/removing displays.
nit: update comment, you've been pretty thorough, but please make sure "git gs
PlatformScreen", "git gs platform_screen", etc. come up empty... I'm guessing
this is simply an outdated reference to a similar "PlatformDisplay" class?

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/user_display...
File services/ui/ws/user_display_manager_unittest.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/user_display...
services/ui/ws/user_display_manager_unittest.cc:113: TestScreenManager&
screen_manager() { return screen_manager_; }
optional nit: flip this to pointer, instead of non-const ref.

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_manag...
File services/ui/ws/window_manager_state_unittest.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_manag...
services/ui/ws/window_manager_state_unittest.cc:550: TestScreenManager
screen_manager;
optional nit: explicit include?

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_tree_...
File services/ui/ws/window_tree_unittest.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_tree_...
services/ui/ws/window_tree_unittest.cc:1358: TestScreenManager screen_manager;
optional nit: explicit include?

[kylechar, 2016-12-01 21:08:21]

Thanks!

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/display_mana...
File services/ui/ws/display_manager.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/display_mana...
services/ui/ws/display_manager.cc:11: #include
"services/ui/display/screen_manager.h"
On 2016/12/01 20:01:18, msw wrote:
> nit: needed?

Nope. Deleted.

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/test_utils.h
File services/ui/ws/test_utils.h (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/test_utils.h...
services/ui/ws/test_utils.h:44: // Test PlatformDisplay instance that allows
adding/modifying/removing displays.
On 2016/12/01 20:01:19, msw wrote:
> nit: update comment, you've been pretty thorough, but please make sure "git gs
> PlatformScreen", "git gs platform_screen", etc. come up empty... I'm guessing
> this is simply an outdated reference to a similar "PlatformDisplay" class?

My bad. I mixed up PlatformDisplay and PlatformScreen when writing the comment
originally. Fixed. I've grepped for PlatformScreen that got missed and didn't
see anything.

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_manag...
File services/ui/ws/window_manager_state_unittest.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_manag...
services/ui/ws/window_manager_state_unittest.cc:550: TestScreenManager
screen_manager;
On 2016/12/01 20:01:19, msw wrote:
> optional nit: explicit include?

It has an #include to services/ui/ws/test_utils.h where TestScreenManager is. We
don't actually use display::ScreenManager here.

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_tree_...
File services/ui/ws/window_tree_unittest.cc (right):

https://codereview.chromium.org/2549503002/diff/1/services/ui/ws/window_tree_...
services/ui/ws/window_tree_unittest.cc:1358: TestScreenManager screen_manager;
On 2016/12/01 20:01:19, msw wrote:
> optional nit: explicit include?

Ditto.

[kylechar, 2016-12-01 21:08:26]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-01 21:08:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2549503002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-12-01 21:08:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:10:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480626506389790,
"parent_rev": "51539b12a9c15aa60dd8d484510214baa2cda298", "commit_rev":
"31148199fad06e74e5634834483f6888f65408fd"}

[commit-bot: I haz the power, 2016-12-01 22:11:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 22:14:24]

Description was changed from

==========
Rename PlatformScreen to ScreenManager.

ScreenManager is more descriptive and is what I've been using in design
docs. Simple update of file and class names.

BUG=none
==========

to

==========
Rename PlatformScreen to ScreenManager.

ScreenManager is more descriptive and is what I've been using in design
docs. Simple update of file and class names.

BUG=none

Committed: https://crrev.com/888325bb4c98cc45b4f5003980918904c7d384d5
Cr-Commit-Position: refs/heads/master@{#435735}
==========

[commit-bot: I haz the power, 2016-12-01 22:14:25]

Patchset 2 (id:??) landed as
https://crrev.com/888325bb4c98cc45b4f5003980918904c7d384d5
Cr-Commit-Position: refs/heads/master@{#435735}