Add IPCs for ash display shortcuts.

Add IPCs for ash display shortcuts.

Add the IPCs and wire the ash keyboard shortcuts in mash. All IPCs are
fire and forget. There is no implementation on the mus side yet, just
stub methods.

BUG=612242
Committed: https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4
Cr-Commit-Position: refs/heads/master@{#435748}

[kylechar, 2016-12-01 16:13:07]

kylechar@chromium.org changed reviewers:
+ jamescook@chromium.org, tsepez@chromium.org

[kylechar, 2016-12-01 16:13:08]

+jamescook for ash/*
+tsepez for security review

[James Cook, 2016-12-01 16:38:50]

Just nits. If you're blocked on this CL feel free to ping me on chat for faster
turnaround on a revision.

It's nice to see the display management stuff being hooked up for mus!

https://codereview.chromium.org/2537643008/diff/1/ash/mus/accelerators/accele...
File ash/mus/accelerators/accelerator_controller_delegate_mus.cc (right):

https://codereview.chromium.org/2537643008/diff/1/ash/mus/accelerators/accele...
ash/mus/accelerators/accelerator_controller_delegate_mus.cc:34: // eventually be
empty. If there are any actions that don't make sense for
The documentation for this function needs to be rewritten. It's now a mix of
things that haven't been ported to Mus (due to usage of aura::Window and not yet
being ported to ash/common) and things that need a mus-specific implementation.

Can you update the docs in this function and add a class comment?

https://codereview.chromium.org/2537643008/diff/1/ash/mus/accelerators/accele...
ash/mus/accelerators/accelerator_controller_delegate_mus.cc:116: case
SCALE_UI_DOWN: {
optional: These constants could be renamed for consistency with the methods they
call.

https://codereview.chromium.org/2537643008/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/display/display_controller.mojom (right):

https://codereview.chromium.org/2537643008/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/display/display_controller.mojom:17:
RotateCurrentDisplay();
How about calling this RotateCurrentDisplayCW() so it self-documents the
direction?

https://codereview.chromium.org/2537643008/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/display/display_controller.mojom:26:
ZoomInternalDisplayUp();
As a non-graphics person I'm not sure if ZoomUp means making things look bigger
or smaller. Maybe ZoomInInternalDisplay? IncreaseInternalDisplayZoom for
symmetry with ResetInternalDisplayZoom?

[Tom Sepez, 2016-12-01 16:42:00]

mojom LGTM, but address comments.  Thanks.

[kylechar, 2016-12-01 18:43:31]

https://codereview.chromium.org/2537643008/diff/1/ash/mus/accelerators/accele...
File ash/mus/accelerators/accelerator_controller_delegate_mus.cc (right):

https://codereview.chromium.org/2537643008/diff/1/ash/mus/accelerators/accele...
ash/mus/accelerators/accelerator_controller_delegate_mus.cc:34: // eventually be
empty. If there are any actions that don't make sense for
On 2016/12/01 16:38:50, James Cook wrote:
> The documentation for this function needs to be rewritten. It's now a mix of
> things that haven't been ported to Mus (due to usage of aura::Window and not
yet
> being ported to ash/common) and things that need a mus-specific
implementation.
> 
> Can you update the docs in this function and add a class comment?

Done.

https://codereview.chromium.org/2537643008/diff/1/services/ui/public/interfac...
File services/ui/public/interfaces/display/display_controller.mojom (right):

https://codereview.chromium.org/2537643008/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/display/display_controller.mojom:17:
RotateCurrentDisplay();
On 2016/12/01 16:38:50, James Cook wrote:
> How about calling this RotateCurrentDisplayCW() so it self-documents the
> direction?

Done.

https://codereview.chromium.org/2537643008/diff/1/services/ui/public/interfac...
services/ui/public/interfaces/display/display_controller.mojom:26:
ZoomInternalDisplayUp();
On 2016/12/01 16:38:50, James Cook wrote:
> As a non-graphics person I'm not sure if ZoomUp means making things look
bigger
> or smaller. Maybe ZoomInInternalDisplay? IncreaseInternalDisplayZoom for
> symmetry with ResetInternalDisplayZoom?

I agree, up/down doesn't make much sense. Changed.

[James Cook, 2016-12-01 18:59:47]

LGTM with naming nit

https://codereview.chromium.org/2537643008/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/display/display_controller.mojom (right):

https://codereview.chromium.org/2537643008/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/display/display_controller.mojom:16:
InternalDisplayIncreaseZoom();
IncreaseInternalDisplayZoom to start with verb?

[kylechar, 2016-12-01 19:02:12]

Thanks!

https://codereview.chromium.org/2537643008/diff/20001/services/ui/public/inte...
File services/ui/public/interfaces/display/display_controller.mojom (right):

https://codereview.chromium.org/2537643008/diff/20001/services/ui/public/inte...
services/ui/public/interfaces/display/display_controller.mojom:16:
InternalDisplayIncreaseZoom();
On 2016/12/01 18:59:47, James Cook wrote:
> IncreaseInternalDisplayZoom to start with verb?

Done.

[kylechar, 2016-12-01 21:27:23]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 21:27:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 22:47:14]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-01 22:50:52]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-01 22:50:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2537643008/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-12-01 22:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:55:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480632652978140,
"parent_rev": "62d1799c39b092c4db49a47cb581237f693875ac", "commit_rev":
"f4058fa238343622913206abfec8a2269c69a12a"}

[commit-bot: I haz the power, 2016-12-01 22:56:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-01 22:58:29]

Description was changed from

==========
Add IPCs for ash display shortcuts.

Add the IPCs and wire the ash keyboard shortcuts in mash. All IPCs are
fire and forget. There is no implementation on the mus side yet, just
stub methods.

BUG=612242
==========

to

==========
Add IPCs for ash display shortcuts.

Add the IPCs and wire the ash keyboard shortcuts in mash. All IPCs are
fire and forget. There is no implementation on the mus side yet, just
stub methods.

BUG=612242

Committed: https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4
Cr-Commit-Position: refs/heads/master@{#435748}
==========

[commit-bot: I haz the power, 2016-12-01 22:58:30]

Patchset 4 (id:??) landed as
https://crrev.com/ef3c1eb093c6c7f93eb8cb8f06d39dfa9152bcc4
Cr-Commit-Position: refs/heads/master@{#435748}