Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Issue 2549393005: Remove ContextLifecycleObserver from SpeechSynthesisUtterance (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from SpeechSynthesisUtterance SpeechSynthesisUtterance inherits from ContextLifecycleObserver just to implement EventTarget::getExecutionContext(). Instead, SpeechSynthesisUtterance should just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/5b8e71f5097eccbf0e60e2b7d6c5ca9461c77de3 Cr-Commit-Position: refs/heads/master@{#436947}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp View 1 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years ago (2016-12-07 12:03:12 UTC) #2
sof
lgtm
4 years ago (2016-12-07 12:05:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549393005/20001
4 years ago (2016-12-07 12:12:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 14:38:29 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 14:40:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b8e71f5097eccbf0e60e2b7d6c5ca9461c77de3
Cr-Commit-Position: refs/heads/master@{#436947}

Powered by Google App Engine
This is Rietveld 408576698