Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp

Issue 2549393005: Remove ContextLifecycleObserver from SpeechSynthesisUtterance (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp b/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
index 14ec0006c43aea35864f82ccceb34493f4b9c3a4..68a83394c177ef1040d35334e8b3ffc56733ebd4 100644
--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
@@ -25,6 +25,8 @@
#include "modules/speech/SpeechSynthesisUtterance.h"
+#include "core/dom/ExecutionContext.h"
+
namespace blink {
SpeechSynthesisUtterance* SpeechSynthesisUtterance::create(
@@ -35,7 +37,7 @@ SpeechSynthesisUtterance* SpeechSynthesisUtterance::create(
SpeechSynthesisUtterance::SpeechSynthesisUtterance(ExecutionContext* context,
const String& text)
- : ContextLifecycleObserver(context),
+ : m_executionContext(context),
m_platformUtterance(PlatformSpeechSynthesisUtterance::create(this)) {
m_platformUtterance->setText(text);
}
@@ -43,7 +45,7 @@ SpeechSynthesisUtterance::SpeechSynthesisUtterance(ExecutionContext* context,
SpeechSynthesisUtterance::~SpeechSynthesisUtterance() {}
ExecutionContext* SpeechSynthesisUtterance::getExecutionContext() const {
- return ContextLifecycleObserver::getExecutionContext();
+ return m_executionContext;
}
const AtomicString& SpeechSynthesisUtterance::interfaceName() const {
@@ -65,10 +67,10 @@ void SpeechSynthesisUtterance::setVoice(SpeechSynthesisVoice* voice) {
}
DEFINE_TRACE(SpeechSynthesisUtterance) {
+ visitor->trace(m_executionContext);
visitor->trace(m_platformUtterance);
visitor->trace(m_voice);
EventTargetWithInlineData::trace(visitor);
- ContextLifecycleObserver::trace(visitor);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698