|
|
Created:
4 years ago by ghost stip (do not use) Modified:
3 years, 11 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd vr_shell_unittests to ansr.
BUG=670147
Review-Url: https://codereview.chromium.org/2549393004
Cr-Commit-Position: refs/heads/master@{#442744}
Committed: https://chromium.googlesource.com/chromium/src/+/d6539dc7b85800f035f1a14e06653497a45aab0c
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add android_devices definition. #Messages
Total messages: 19 (10 generated)
Description was changed from ========== Add vr_shell_unittests to ansr. BUG=670147 ========== to ========== Add vr_shell_unittests to ansr. BUG=670147 ==========
stip@chromium.org changed reviewers: + bsheedy@chromium.org, jbudorick@chromium.org
The CQ bit was checked by stip@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
lgtm w/ q https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:1227: { Should this have a required minimum number of devices?
On 2016/12/07 21:58:04, jbudorick wrote: > lgtm w/ q > > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... > File testing/buildbot/chromium.android.json (right): > > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... > testing/buildbot/chromium.android.json:1227: { > Should this have a required minimum number of devices? All the other tests seem to have a minimum number set, so I would imagine so. WDYT stip@?
Friendly reminder that this still exists.
https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:1227: { On 2016/12/07 21:58:03, jbudorick (ooo until Monday) wrote: > Should this have a required minimum number of devices? If stip doesn't respond today, set the minimum number of devices to 4 and land this.
On 2017/01/09 15:11:07, jbudorick wrote: > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... > File testing/buildbot/chromium.android.json (right): > > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.a... > testing/buildbot/chromium.android.json:1227: { > On 2016/12/07 21:58:03, jbudorick (ooo until Monday) wrote: > > Should this have a required minimum number of devices? > > If stip doesn't respond today, set the minimum number of devices to 4 and land > this. er, realized this is stip's CL. If stip doesn't respond today, we can upload a dupe w/ minimum devices set to 4 and land that.
Sorry for the delay on this! I've uploaded the new version, committing now.
The CQ bit was checked by stip@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bsheedy@chromium.org, jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2549393004/#ps20001 (title: "Add android_devices definition.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484089457592360, "parent_rev": "d7ab6d03146c909de6078e21b59a4cdeb0b233d2", "commit_rev": "d6539dc7b85800f035f1a14e06653497a45aab0c"}
Message was sent while issue was closed.
Description was changed from ========== Add vr_shell_unittests to ansr. BUG=670147 ========== to ========== Add vr_shell_unittests to ansr. BUG=670147 Review-Url: https://codereview.chromium.org/2549393004 Cr-Commit-Position: refs/heads/master@{#442744} Committed: https://chromium.googlesource.com/chromium/src/+/d6539dc7b85800f035f1a14e0665... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d6539dc7b85800f035f1a14e0665... |