Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2549393004: Add vr_shell_unittests to ansr. (Closed)

Created:
4 years ago by ghost stip (do not use)
Modified:
3 years, 11 months ago
Reviewers:
bsheedy, jbudorick
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add vr_shell_unittests to ansr. BUG=670147 Review-Url: https://codereview.chromium.org/2549393004 Cr-Commit-Position: refs/heads/master@{#442744} Committed: https://chromium.googlesource.com/chromium/src/+/d6539dc7b85800f035f1a14e06653497a45aab0c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add android_devices definition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M testing/buildbot/chromium.android.json View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
bsheedy
LGTM
4 years ago (2016-12-07 21:34:49 UTC) #7
jbudorick
lgtm w/ q https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json#newcode1227 testing/buildbot/chromium.android.json:1227: { Should this have a required ...
4 years ago (2016-12-07 21:58:04 UTC) #8
bsheedy
On 2016/12/07 21:58:04, jbudorick wrote: > lgtm w/ q > > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json > File testing/buildbot/chromium.android.json ...
4 years ago (2016-12-13 17:55:37 UTC) #9
bsheedy
Friendly reminder that this still exists.
3 years, 11 months ago (2017-01-06 18:44:29 UTC) #10
jbudorick
https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json#newcode1227 testing/buildbot/chromium.android.json:1227: { On 2016/12/07 21:58:03, jbudorick (ooo until Monday) wrote: ...
3 years, 11 months ago (2017-01-09 15:11:07 UTC) #11
jbudorick
On 2017/01/09 15:11:07, jbudorick wrote: > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json > File testing/buildbot/chromium.android.json (right): > > https://codereview.chromium.org/2549393004/diff/1/testing/buildbot/chromium.android.json#newcode1227 > ...
3 years, 11 months ago (2017-01-09 15:12:02 UTC) #12
ghost stip (do not use)
Sorry for the delay on this! I've uploaded the new version, committing now.
3 years, 11 months ago (2017-01-10 23:01:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549393004/20001
3 years, 11 months ago (2017-01-10 23:05:11 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 00:51:47 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d6539dc7b85800f035f1a14e0665...

Powered by Google App Engine
This is Rietveld 408576698