Issue 254923002: Oilpan: move DOMException to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254923002: Oilpan: move DOMException to the heap. (Closed)

Created:
6 years, 8 months ago by sof

Modified:
6 years, 8 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, tzik, eae+blinkwatch, adamk+blink_chromium.org, rwlbuis, Nils Barth (inactive), jsbell+serviceworker_chromium.org, chrishtr, arv+blink, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, ojan, sof, nhiroki, kinuko, Nate Chapin, alecflett+watch_chromium.org, jsbell+bindings_chromium.org, serviceworker-reviews, kouhei+bindings_chromium.org, falken, Inactive, horo+watch_chromium.org, watchdog-blink-watchlist_google.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: move DOMException to the heap. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172708

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -8 lines)			Patch
M	Source/bindings/v8/V8ThrowException.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DOMException.h	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/core/dom/DOMException.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/DOMException.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/modules/serviceworkers/ServiceWorkerError.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/serviceworkers/ServiceWorkerError.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/254923002/1

6 years, 8 months ago (2014-04-27 10:26:24 UTC) #4

Message was sent while issue was closed.

Change committed as 172708

Expand Messages | Collapse Messages