Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: Source/core/dom/DOMException.h

Issue 254923002: Oilpan: move DOMException to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8ThrowException.cpp ('k') | Source/core/dom/DOMException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DOMException.h
diff --git a/Source/core/dom/DOMException.h b/Source/core/dom/DOMException.h
index ade90d63abfc3dfeb2266939ed9c46ff029c9c94..221a312337c40c9135ffba09df384e489917b7f5 100644
--- a/Source/core/dom/DOMException.h
+++ b/Source/core/dom/DOMException.h
@@ -30,6 +30,7 @@
#define DOMException_h
#include "bindings/v8/ScriptWrappable.h"
+#include "platform/heap/Handle.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
#include "wtf/text/WTFString.h"
@@ -38,9 +39,9 @@ namespace WebCore {
typedef int ExceptionCode;
-class DOMException : public RefCounted<DOMException>, public ScriptWrappable {
+class DOMException FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMException>, public ScriptWrappable {
public:
- static PassRefPtr<DOMException> create(ExceptionCode, const String& sanitizedMessage = String(), const String& unsanitizedMessage = String());
+ static PassRefPtrWillBeRawPtr<DOMException> create(ExceptionCode, const String& sanitizedMessage = String(), const String& unsanitizedMessage = String());
unsigned short code() const { return m_code; }
String name() const { return m_name; }
@@ -56,6 +57,8 @@ public:
static String getErrorName(ExceptionCode);
static String getErrorMessage(ExceptionCode);
+ void trace(Visitor*) { }
+
private:
DOMException(unsigned short m_code, const String& name, const String& sanitizedMessage, const String& unsanitizedMessage);
« no previous file with comments | « Source/bindings/v8/V8ThrowException.cpp ('k') | Source/core/dom/DOMException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698