Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.h

Issue 2549163002: RemoteContentSuggestions: Stores the time of the last successful background fetch in a pref (Closed)
Patch Set: Address comments treib Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.h b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
index 62437c99096287262a34c2022b1411af6ca86f7f..772aa0599b2b9389d58102bb989494c03330847a 100644
--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
@@ -80,12 +80,6 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
using FetchedCategoriesVector = std::vector<FetchedCategory>;
using OptionalFetchedCategories = base::Optional<FetchedCategoriesVector>;
- // |snippets| contains parsed snippets if a fetch succeeded. If problems
- // occur, |snippets| contains no value (no actual vector in base::Optional).
- // Error details can be retrieved using last_status().
- using SnippetsAvailableCallback =
- base::OnceCallback<void(OptionalFetchedCategories fetched_categories)>;
-
// Enumeration listing all possible outcomes for fetch attempts. Used for UMA
// histograms, so do not change existing values. Insert new values at the end,
// and update the histogram definition.
@@ -102,6 +96,13 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
RESULT_MAX
};
+ // |snippets| contains parsed snippets if a fetch succeeded. If problems
+ // occur, |snippets| contains no value (no actual vector in base::Optional).
+ // Error details can be retrieved using last_status().
+ using SnippetsAvailableCallback =
+ base::OnceCallback<void(FetchResult fetch_result,
+ OptionalFetchedCategories fetched_categories)>;
+
// Enumeration listing all possible variants of dealing with personalization.
enum class Personalization { kPersonal, kNonPersonal, kBoth };

Powered by Google App Engine
This is Rietveld 408576698