components/ntp_snippets/remote/ntp_snippets_fetcher.cc - Issue 2549163002: RemoteContentSuggestions: Stores the time of the last successful background fetch in a pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.cc

Issue 2549163002: RemoteContentSuggestions: Stores the time of the last successful background fetch in a pref (Closed)

Patch Set: Address comments treib Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/remote/ntp_snippets_fetcher.cc

diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.cc b/components/ntp_snippets/remote/ntp_snippets_fetcher.cc

index 62236a8a375cab50981b1a7798b0ce55f963798c..76ec5f1e74585dcc93d1db4bacd49745612ecec3 100644

--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.cc

+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.cc

@@ -1005,7 +1005,7 @@ void NTPSnippetsFetcher::FetchFinished(OptionalFetchedCategories categories,

DVLOG(1) << "Fetch finished: " << last_status_;

- std::move(callback).Run(std::move(categories));

+ std::move(callback).Run(status_code, std::move(categories));

}

bool NTPSnippetsFetcher::JsonToSnippets(const base::Value& parsed,