Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: net/http/http_util.h

Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader(). (Closed)
Patch Set: Fixed unittest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_response_headers_unittest.cc ('k') | net/http/http_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_util.h
diff --git a/net/http/http_util.h b/net/http/http_util.h
index a0ee9bba79dfab0d366268deb740233e83f4e555..de4b1a69e032ce45481e41541aa395e2fdaa0cbf 100644
--- a/net/http/http_util.h
+++ b/net/http/http_util.h
@@ -60,20 +60,18 @@ class NET_EXPORT HttpUtil {
static bool ParseRangeHeader(const std::string& range_specifier,
std::vector<HttpByteRange>* ranges);
- // Extracts the values in a Content-Range header and returns true if they are
- // valid for a 206 response; otherwise returns false.
+ // Extracts the values in a Content-Range header and returns true if all three
+ // values are present and valid for a 206 response; otherwise returns false.
// The following values will be outputted:
// |*first_byte_position| = inclusive position of the first byte of the range
// |*last_byte_position| = inclusive position of the last byte of the range
// |*instance_length| = size in bytes of the object requested
- // If any of the above values is unknown, its value will be -1.
- // TODO(sclittle): Change this method to only support Content-Range headers
- // from 206 responses, since right now it only has incomplete support for
- // Content-Range headers from 416 responses. See crbug.com/670913.
- static bool ParseContentRangeHeader(base::StringPiece content_range_spec,
- int64_t* first_byte_position,
- int64_t* last_byte_position,
- int64_t* instance_length);
+ // If this method returns false, then all of the outputs will be -1.
+ static bool ParseContentRangeHeaderFor206(
+ base::StringPiece content_range_spec,
+ int64_t* first_byte_position,
+ int64_t* last_byte_position,
+ int64_t* instance_length);
// Parses a Retry-After header that is either an absolute date/time or a
// number of seconds in the future. Interprets absolute times as relative to
« no previous file with comments | « net/http/http_response_headers_unittest.cc ('k') | net/http/http_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698