Cleaned up the API of HttpUtil::ParseContentRangeHeader().

net/http/http_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_UTIL_H_
 #define NET_HTTP_HTTP_UTIL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 42 matching lines @@
   // "Range" header is defined in RFC 7233 Section 2.1.
   // https://tools.ietf.org/html/rfc7233#section-2.1
   static bool ParseRanges(const std::string& headers,
                           std::vector<HttpByteRange>* ranges);
 
   // Same thing as ParseRanges except the Range header is known and its value
   // is directly passed in, rather than requiring searching through a string.
   static bool ParseRangeHeader(const std::string& range_specifier,
                                std::vector<HttpByteRange>* ranges);
 
-  // Extracts the values in a Content-Range header and returns true if they are
-  // valid for a 206 response; otherwise returns false.
+  // Extracts the values in a Content-Range header and returns true if all three
+  // values are present and valid for a 206 response; otherwise returns false.
   // The following values will be outputted:
   // |*first_byte_position| = inclusive position of the first byte of the range
   // |*last_byte_position| = inclusive position of the last byte of the range
   // |*instance_length| = size in bytes of the object requested
-  // If any of the above values is unknown, its value will be -1.
-  // TODO(sclittle): Change this method to only support Content-Range headers
-  // from 206 responses, since right now it only has incomplete support for
-  // Content-Range headers from 416 responses. See crbug.com/670913.
-  static bool ParseContentRangeHeader(base::StringPiece content_range_spec,
-                                      int64_t* first_byte_position,
-                                      int64_t* last_byte_position,
-                                      int64_t* instance_length);
+  // If this method returns false, then all of the outputs will be -1.
+  static bool ParseContentRangeHeaderFor206(
+      base::StringPiece content_range_spec,
+      int64_t* first_byte_position,
+      int64_t* last_byte_position,
+      int64_t* instance_length);
 
   // Parses a Retry-After header that is either an absolute date/time or a
   // number of seconds in the future. Interprets absolute times as relative to
   // |now|. If |retry_after_string| is successfully parsed and indicates a time
   // that is not in the past, fills in |*retry_after| and returns true;
   // otherwise, returns false.
   static bool ParseRetryAfterHeader(const std::string& retry_after_string,
                                     base::Time now,
                                     base::TimeDelta* retry_after);
 
@@ skipping 367 matching lines @@
     // True if quotes values are required to be properly quoted; false if
     // mismatched quotes and other problems with quoted values should be more
     // or less gracefully treated as valid.
     bool strict_quotes_;
   };
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_UTIL_H_