content/browser/download/download_request_core.cc - Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_request_core.cc

Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader(). (Closed)

Patch Set: Fixed unittest Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_request_core.cc

diff --git a/content/browser/download/download_request_core.cc b/content/browser/download/download_request_core.cc

index f23dcda4bf2270fd276a3f387260bdb0b76bbd3c..09833c85df9ae161f21ec46e81e384bbb4442234 100644

--- a/content/browser/download/download_request_core.cc

+++ b/content/browser/download/download_request_core.cc

@@ -610,7 +610,7 @@ DownloadInterruptReason DownloadRequestCore::HandleSuccessfulServerResponse(

int64_t first_byte = -1;

int64_t last_byte = -1;

int64_t length = -1;

- if (!http_headers.GetContentRange(&first_byte, &last_byte, &length))

+ if (!http_headers.GetContentRangeFor206(&first_byte, &last_byte, &length))

return DOWNLOAD_INTERRUPT_REASON_SERVER_BAD_CONTENT;

DCHECK_GE(first_byte, 0);