content/browser/blob_storage/blob_url_request_job_unittest.cc - Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/blob_storage/blob_url_request_job_unittest.cc

Issue 2549143003: Cleaned up the API of HttpUtil::ParseContentRangeHeader(). (Closed)

Patch Set: Fixed unittest Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/blob_storage/blob_url_request_job_unittest.cc

diff --git a/content/browser/blob_storage/blob_url_request_job_unittest.cc b/content/browser/blob_storage/blob_url_request_job_unittest.cc

index ee5c67a6e6146a61a55e334a7e77ad2f53965c12..bf7a7611c135dc22818aab60c30eefb20173acb2 100644

--- a/content/browser/blob_storage/blob_url_request_job_unittest.cc

+++ b/content/browser/blob_storage/blob_url_request_job_unittest.cc

@@ -495,8 +495,8 @@ TEST_F(BlobURLRequestJobTest, TestGetRangeRequest1) {

EXPECT_FALSE(url_request_delegate_.metadata());

int64_t first = 0, last = 0, length = 0;

- EXPECT_TRUE(

- request_->response_headers()->GetContentRange(&first, &last, &length));

+ EXPECT_TRUE(request_->response_headers()->GetContentRangeFor206(&first, &last,

+ &length));

EXPECT_EQ(5, first);

EXPECT_EQ(10, last);

EXPECT_EQ(GetTotalBlobLength(), length);

@@ -518,8 +518,8 @@ TEST_F(BlobURLRequestJobTest, TestGetRangeRequest2) {

int64_t total = GetTotalBlobLength();

int64_t first = 0, last = 0, length = 0;

- EXPECT_TRUE(

- request_->response_headers()->GetContentRange(&first, &last, &length));

+ EXPECT_TRUE(request_->response_headers()->GetContentRangeFor206(&first, &last,

+ &length));

EXPECT_EQ(total - 10, first);

EXPECT_EQ(total - 1, last);

EXPECT_EQ(total, length);

@@ -540,8 +540,8 @@ TEST_F(BlobURLRequestJobTest, TestGetRangeRequest3) {

EXPECT_FALSE(url_request_delegate_.metadata());

int64_t first = 0, last = 0, length = 0;

- EXPECT_TRUE(

- request_->response_headers()->GetContentRange(&first, &last, &length));

+ EXPECT_TRUE(request_->response_headers()->GetContentRangeFor206(&first, &last,

+ &length));

EXPECT_EQ(0, first);

EXPECT_EQ(2, last);

EXPECT_EQ(GetTotalBlobLength(), length);