[MD History] Color tweaks.

chrome/browser/resources/md_history/shared_vars.html

Index: chrome/browser/resources/md_history/shared_vars.html
diff --git a/chrome/browser/resources/md_history/shared_vars.html b/chrome/browser/resources/md_history/shared_vars.html
index 967e990542cfdbbce5685cec55742bb3ee947c03..248fb51cfbc46c7b60f3ec5d2ee5963173cd8bd1 100644
--- a/chrome/browser/resources/md_history/shared_vars.html
+++ b/chrome/browser/resources/md_history/shared_vars.html
@@ -1,3 +1,5 @@
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html">
+
 <style is="custom-style">
   :root {
     --card-border-color: rgba(0, 0, 0, 0.14);
@@ -13,12 +15,21 @@
       padding: 0 var(--card-padding-side);
       width: calc(100% - 2 * var(--card-padding-side));
     };
+    --drawer-header-color: #666;

[tsergeant, 2016/12/06 06:45:00]

This used to be rgb(66, 66, 66)

aka #424242,

aka --google-grey-800.

Was this a deliberate change?

[calamity, 2016/12/08 06:36:34]

Ooooops.

     --first-card-padding-top: 24px;
+    --history-item-time-color: #646464;
     --item-height: 44px;
     --primary-text-color: #333;

[tsergeant, 2016/12/06 06:45:00]

Here's where it gets interesting: Primary color, according to the Settings
specs, should be #424242 (--paper-grey-800). Both History and Bookmarks specs
currently say #333, though.

I have no idea whether this is a deliberate difference. We should check.

If it's -not- a deliberate difference, we can consolidate a couple of other
things under --primary-text-color.

[calamity, 2016/12/08 06:36:34]

Sent an email.

     --secondary-text-color: #757575;
+    --separator-color: rgba(0, 0, 0, 0.08);
     --side-bar-width: 256px;
+    --sidebar-footer-link-color: var(--google-blue-700);

[tsergeant, 2016/12/06 06:45:00]

Again, referring to the settings spec, --google-blue-700 is the general link
color. Can we consolidate --sidebar-footer-link-color and
--sidebar-selected-color into a single variable like --link-color?

(Settings also applies this color to all <a> tags in their shared CSS module)

[calamity, 2016/12/08 06:36:34]

Done.

+    --sidebar-footer-text-color: #6e6e6e;
+    --sidebar-selected-color: var(--google-blue-700);
+    --sidebar-unselected-color: #5a5a5a;
+    --synced-devices-notice-color: var(--paper-grey-800);
     --toolbar-grouped-height: 101px;
     --toolbar-height: 56px;
+    --toolbar-selected-color: rgb(68, 136, 255);

[tsergeant, 2016/12/06 06:45:00]

This is --google-blue-500

(aka --checked-color)

which, according to the settings spec is the general color for interactive
elements like toggles and buttons.

Can we consolidate this down into something like --interactive-color?

[calamity, 2016/12/08 06:36:34]

Done.

   }
 </style>