[debug] Remove DebugInterface class

[debug] Remove DebugInterface class

It only contained type definitions and static functions, so we
can also just make it a namespace.

R=kozyatinskiy@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/e6bd3063535d76a94c9bd62fb18a537430d50835
Cr-Commit-Position: refs/heads/master@{#41501}

[Clemens Hammacher, 2016-12-05 13:26:19]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:26:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-05 13:36:08]

https://codereview.chromium.org/2549133002/diff/1/src/debug/debug-interface.h
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2549133002/diff/1/src/debug/debug-interface.h...
src/debug/debug-interface.h:17: class DebugInterface {
I actually meant to remove this class altogether. It only contains types,
classes, and static functions anyways.

[commit-bot: I haz the power, 2016-12-05 13:55:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 13:55:08]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-12-05 18:36:12]

rs inspector lgtm

[Clemens Hammacher, 2016-12-05 18:37:31]

Description was changed from

==========
[debug] Move more types to v8::debug namespace

This CL moves more type definitions from debug-interface.h to
interface-types.h, also moving them from inner classes of
v8::DebugInterface to outer classes in the v8::debug namespace.
Also the v8::DebugInterface class now resides in the v8::debug
namespace.

R=kozyatinskiy@chromium.org, yangguo@chromium.org
==========

to

==========
[debug] Remove DebugInterface class

It only contained type definitions and static functions, so we
can also just make it a namespace.

R=kozyatinskiy@chromium.org, yangguo@chromium.org
==========

[Clemens Hammacher, 2016-12-05 18:38:07]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 18:38:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-12-05 18:38:22]

https://codereview.chromium.org/2549133002/diff/1/src/debug/debug-interface.h
File src/debug/debug-interface.h (right):

https://codereview.chromium.org/2549133002/diff/1/src/debug/debug-interface.h...
src/debug/debug-interface.h:17: class DebugInterface {
On 2016/12/05 at 13:36:08, Yang wrote:
> I actually meant to remove this class altogether. It only contains types,
classes, and static functions anyways.

Oh, I see. Fixed.

[Yang, 2016-12-05 18:48:36]

lgtm with a comment. thanks for doing this!

https://codereview.chromium.org/2549133002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2549133002/diff/20001/src/api.cc#newcode8839
src/api.cc:8839: bool debug::SetDebugEventListener(Isolate* isolate,
debug::EventCallback that,
wouldn't it make sense to wrap all of this in a

namespace debug {

}

?

[Clemens Hammacher, 2016-12-05 19:02:14]

https://codereview.chromium.org/2549133002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2549133002/diff/20001/src/api.cc#newcode8839
src/api.cc:8839: bool debug::SetDebugEventListener(Isolate* isolate,
debug::EventCallback that,
On 2016/12/05 at 18:48:36, Yang wrote:
> wouldn't it make sense to wrap all of this in a
> 
> namespace debug {
> 
> }
> 
> ?

Depends (probably mostly a matter of style).
I like it this way because it will give you a compile error if you change the
signature in the header file (or remove the declaration) and forget to change
the code here.

[Yang, 2016-12-05 19:23:16]

On 2016/12/05 19:02:14, Clemens Hammacher wrote:
> https://codereview.chromium.org/2549133002/diff/20001/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/2549133002/diff/20001/src/api.cc#newcode8839
> src/api.cc:8839: bool debug::SetDebugEventListener(Isolate* isolate,
> debug::EventCallback that,
> On 2016/12/05 at 18:48:36, Yang wrote:
> > wouldn't it make sense to wrap all of this in a
> > 
> > namespace debug {
> > 
> > }
> > 
> > ?
> 
> Depends (probably mostly a matter of style).
> I like it this way because it will give you a compile error if you change the
> signature in the header file (or remove the declaration) and forget to change
> the code here.

I see. Bikeshedding anyways. LGTM.

[commit-bot: I haz the power, 2016-12-05 19:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 19:29:56]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-05 19:41:44]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-12-05 19:41:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2549133002/#ps20001
(title: "Fix overall CL ;)")

[commit-bot: I haz the power, 2016-12-05 19:41:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 19:44:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480966904807270,
"parent_rev": "95307eb555907962768e7adc49ce47b8927fa970", "commit_rev":
"5d320d53b50870560b4b5c7894f728d9ceb3d308"}

[commit-bot: I haz the power, 2016-12-05 19:44:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 19:44:58]

Description was changed from

==========
[debug] Remove DebugInterface class

It only contained type definitions and static functions, so we
can also just make it a namespace.

R=kozyatinskiy@chromium.org, yangguo@chromium.org
==========

to

==========
[debug] Remove DebugInterface class

It only contained type definitions and static functions, so we
can also just make it a namespace.

R=kozyatinskiy@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/e6bd3063535d76a94c9bd62fb18a537430d50835
Cr-Commit-Position: refs/heads/master@{#41501}
==========

[commit-bot: I haz the power, 2016-12-05 19:44:59]

Patchset 2 (id:??) landed as
https://crrev.com/e6bd3063535d76a94c9bd62fb18a537430d50835
Cr-Commit-Position: refs/heads/master@{#41501}