[debug] Remove DebugInterface class

src/debug/debug-interface.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DEBUG_DEBUG_INTERFACE_H_
 #define V8_DEBUG_DEBUG_INTERFACE_H_
 
 #include "include/v8-debug.h"
 #include "include/v8-util.h"
 #include "include/v8.h"
 
 #include "src/debug/interface-types.h"
 
 namespace v8 {
+namespace debug {
 
 class DebugInterface {

[Yang, 2016/12/05 13:36:08]

I actually meant to remove this class altogether. It only contains types,
classes, and static functions anyways.

[Clemens Hammacher, 2016/12/05 18:38:22]

Oh, I see. Fixed.

  public:
   /**
-   * An event details object passed to the debug event listener.
-   */
-  class EventDetails : public v8::Debug::EventDetails {
-   public:
-    /**
-     * Event type.
-     */
-    virtual v8::DebugEvent GetEvent() const = 0;
-
-    /**
-     * Access to execution state and event data of the debug event. Don't store
-     * these cross callbacks as their content becomes invalid.
-     */
-    virtual Local<Object> GetExecutionState() const = 0;
-    virtual Local<Object> GetEventData() const = 0;
-
-    /**
-     * Get the context active when the debug event happened. Note this is not
-     * the current active context as the JavaScript part of the debugger is
-     * running in its own context which is entered at this point.
-     */
-    virtual Local<Context> GetEventContext() const = 0;
-
-    /**
-     * Client data passed with the corresponding callback when it was
-     * registered.
-     */
-    virtual Local<Value> GetCallbackData() const = 0;
-
-    virtual ~EventDetails() {}
-  };
-
-  /**
    * Debug event callback function.
    *
    * \param event_details object providing information about the debug event
    *
    * A EventCallback does not take possession of the event data,
    * and must not rely on the data persisting after the handler returns.
    */
   typedef void (*EventCallback)(const EventDetails& event_details);
 
   static bool SetDebugEventListener(Isolate* isolate, EventCallback that,
@@ skipping 47 matching lines @@
   static void CancelDebugBreak(Isolate* isolate);
 
   /**
    * Returns array of internal properties specific to the value type. Result has
    * the following format: [<name>, <value>,...,<name>, <value>]. Result array
    * will be allocated in the current context.
    */
   static MaybeLocal<Array> GetInternalProperties(Isolate* isolate,
                                                  Local<Value> value);
 
-  enum ExceptionBreakState {
-    NoBreakOnException = 0,
-    BreakOnUncaughtException = 1,
-    BreakOnAnyException = 2
-  };
-
   /**
    * Defines if VM will pause on exceptions or not.
    * If BreakOnAnyExceptions is set then VM will pause on caught and uncaught
    * exception, if BreakOnUncaughtException is set then VM will pause only on
    * uncaught exception, otherwise VM won't stop on any exception.
    */
   static void ChangeBreakOnException(Isolate* isolate,
                                      ExceptionBreakState state);
 
-  enum StepAction {
-    StepOut = 0,   // Step out of the current function.
-    StepNext = 1,  // Step to the next statement in the current function.
-    StepIn = 2,    // Step into new functions invoked or the next statement
-                   // in the current function.
-    StepFrame = 3  // Step into a new frame or return to previous frame.
-  };
-
   static void PrepareStep(Isolate* isolate, StepAction action);
   static void ClearStepping(Isolate* isolate);
 
-  /**
-   * Native wrapper around v8::internal::Script object.
-   */
-  class Script {
-   public:
-    v8::Isolate* GetIsolate() const;
-
-    ScriptOriginOptions OriginOptions() const;
-    bool WasCompiled() const;
-    int Id() const;
-    int LineOffset() const;
-    int ColumnOffset() const;
-    std::vector<int> LineEnds() const;
-    MaybeLocal<String> Name() const;
-    MaybeLocal<String> SourceURL() const;
-    MaybeLocal<String> SourceMappingURL() const;
-    MaybeLocal<String> ContextData() const;
-    MaybeLocal<String> Source() const;
-    bool IsWasm() const;
-    bool GetPossibleBreakpoints(const debug::Location& start,
-                                const debug::Location& end,
-                                std::vector<debug::Location>* locations) const;
-
-    /**
-     * script parameter is a wrapper v8::internal::JSObject for
-     * v8::internal::Script.
-     * This function gets v8::internal::Script from v8::internal::JSObject and
-     * wraps it with DebugInterface::Script.
-     * Returns empty local if not called with a valid wrapper of
-     * v8::internal::Script.
-     */
-    static MaybeLocal<Script> Wrap(Isolate* isolate,
-                                   v8::Local<v8::Object> script);
-
-   private:
-    int GetSourcePosition(const debug::Location& location) const;
-  };
-
   static void GetLoadedScripts(Isolate* isolate,
                                PersistentValueVector<Script>& scripts);
 
   /**
    * Compute the disassembly of a wasm function.
    */
   static debug::WasmDisassembly DisassembleWasmFunction(
       Isolate* isolate, v8::Local<v8::Object> script, int function_index);
 
   static MaybeLocal<UnboundScript> CompileInspectorScript(Isolate* isolate,
                                                           Local<String> source);
 };
 
+}  // namespace debug
 }  // namespace v8
 
 #endif  // V8_DEBUG_DEBUG_INTERFACE_H_