Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2549073004: Update order summary total when instruments change. (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update order summary total when instruments change. If the user selects a payment instrument that matches a modifier, then the order summary total should be updated. For example, if the merchant provides discounts for "visa", then selecting a "visa" type card should update the total accordingly. This feature is behind chrome://flags#web-payments-modifiers flag. BUG=660926 Committed: https://crrev.com/a16a3356e94a792374ddbeea5cada71d531e6ad4 Cr-Commit-Position: refs/heads/master@{#436492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 4 chunks +28 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
please use gerrit instead
tedchoc, ptal. The video of the UI change is in http://crbug.com/660926#c7.
4 years ago (2016-12-05 18:25:27 UTC) #4
Ted C
lgtm
4 years ago (2016-12-06 00:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549073004/1
4 years ago (2016-12-06 01:49:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 02:41:45 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 02:45:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a16a3356e94a792374ddbeea5cada71d531e6ad4
Cr-Commit-Position: refs/heads/master@{#436492}

Powered by Google App Engine
This is Rietveld 408576698