Show additional display items when instruments change.

Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will also be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
Committed: https://crrev.com/a01e730142a80a46539e66684ed3dc8f8354fa5d
Cr-Commit-Position: refs/heads/master@{#437347}

[please use gerrit instead, 2016-12-05 23:57:09]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 23:57:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 01:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 01:18:25]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[please use gerrit instead, 2016-12-07 16:39:48]

Description was changed from

==========
Show additional display items

BUG=660926
==========

to

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items
from the modifier. For example, if the merchant
provides discounts for "visa", then selecting a "visa" type card should
show the "VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

[please use gerrit instead, 2016-12-07 16:40:37]

Description was changed from

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items
from the modifier. For example, if the merchant
provides discounts for "visa", then selecting a "visa" type card should
show the "VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

to

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

[please use gerrit instead, 2016-12-07 16:42:10]

Description was changed from

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

to

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will also be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

[please use gerrit instead, 2016-12-07 16:44:40]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-12-07 16:44:41]

Dan, ptal.

[gone, 2016-12-08 19:38:59]

lgtm

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java
(right):

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java:79:
* @param additionalContents The additional shopping cart items. can be null.
Can

[gone, 2016-12-08 19:41:14]

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:652:
? null
git cl format?  Did something funky here and a bunch of other places.

[please use gerrit instead, 2016-12-08 19:45:06]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-12-08 19:45:11]

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:652:
? null
On 2016/12/08 19:41:14, dfalcantara (check my queue) wrote:
> git cl format?  Did something funky here and a bunch of other places.

Yep. What do you do for formatting. Eclipse?

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java
(right):

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java:79:
* @param additionalContents The additional shopping cart items. can be null.
On 2016/12/08 19:38:59, dfalcantara (check my queue) wrote:
> Can

Done.

[commit-bot: I haz the power, 2016-12-08 19:45:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-12-08 19:48:14]

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2549313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:652:
? null
On 2016/12/08 19:45:11, rouslan wrote:
> On 2016/12/08 19:41:14, dfalcantara (check my queue) wrote:
> > git cl format?  Did something funky here and a bunch of other places.
> 
> Yep. What do you do for formatting. Eclipse?

Combo of git cl format and manual eyeballing.  Unfortunately git cl format makes
some weird decisions sometimes, like indenting at 80 for java comments IIRC.

[please use gerrit instead, 2016-12-08 19:55:55]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 19:56:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-12-08 20:01:39]

Ran PaymentRequestImpl.java through Eclipse for formatting. Should be better
now.

[please use gerrit instead, 2016-12-08 20:01:57]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-12-08 20:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2549313002/#ps60001
(title: "Reformat #2")

[commit-bot: I haz the power, 2016-12-08 20:03:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 21:28:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481227317093660,
"parent_rev": "c0f45dda07f1ddbb2b792d4af841d9db9cddc0c1", "commit_rev":
"77b1106d0795de9583158efde2424751abe5f4f9"}

[commit-bot: I haz the power, 2016-12-08 21:29:33]

Description was changed from

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will also be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

to

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will also be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

[commit-bot: I haz the power, 2016-12-08 21:29:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-08 21:32:14]

Description was changed from

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will also be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926
==========

to

==========
Show additional display items when instruments change.

If the user selects a payment instrument that matches a modifier, then
the contents of the shopping cart should show the additional display
items from the modifier. For example, if the merchant provides
discounts for "visa", then selecting a "visa" type card should show the
"VISA discount $5.00" line item in the shopping cart.

This is accomplished by keeping track of the full modifier, instead of
just the total. This will also be useful in upcoming patch where the
modifier contents will be sent to the payment app.

This feature is behind chrome://flags#web-payments-modifiers flag.

This patch additionally removes the no longer used variable
"totalCurrency".

BUG=660926

Committed: https://crrev.com/a01e730142a80a46539e66684ed3dc8f8354fa5d
Cr-Commit-Position: refs/heads/master@{#437347}
==========

[commit-bot: I haz the power, 2016-12-08 21:32:15]

Patchset 4 (id:??) landed as
https://crrev.com/a01e730142a80a46539e66684ed3dc8f8354fa5d
Cr-Commit-Position: refs/heads/master@{#437347}