Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 254883004: Revert 266624 "cc: Split animating and drawing into separate act..." (Closed)

Created:
6 years, 7 months ago by Sami
Modified:
6 years, 7 months ago
Reviewers:
Sami
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 266624 "cc: Split animating and drawing into separate act..." > cc: Split animating and drawing into separate actions > > Split impl-side animating and drawing into separate actions. This is > needed to allow for the possibility of a commit between animating and > drawing so that the main thread gets a chance to consume the new > animation state. In particular this allows the main thread to > synchronize with a fling animation using an onscroll handler. > > BUG=347366 > > Review URL: https://codereview.chromium.org/206793003 Reason for revert: Broke some downstream unit tests. TBR=skyostil@chromium.org BUG=368064 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -427 lines) Patch
M trunk/src/cc/animation/layer_animation_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/input/input_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/scheduler/scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine.h View 5 chunks +1 line, -8 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine.cc View 14 chunks +6 lines, -45 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_state_machine_unittest.cc View 31 chunks +0 lines, -111 lines 0 comments Download
M trunk/src/cc/scheduler/scheduler_unittest.cc View 17 chunks +16 lines, -36 lines 0 comments Download
M trunk/src/cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.cc View 8 chunks +16 lines, -21 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 16 chunks +8 lines, -38 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.h View 3 chunks +3 lines, -10 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.cc View 6 chunks +13 lines, -28 lines 0 comments Download
M trunk/src/content/renderer/input/input_handler_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/renderer/input/input_handler_proxy_unittest.cc View 34 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sami
6 years, 7 months ago (2014-04-29 15:44:19 UTC) #1
Sami
6 years, 7 months ago (2014-04-29 15:50:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266895.

Powered by Google App Engine
This is Rietveld 408576698