Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2548783002: Fix for building with ancient toolchain (Closed)

Created:
4 years ago by hugoh_UTC2
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, Julie Parent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for building with ancient toolchain At Opera we test our SDK on an old MIPS device with a peculiar toolchain. To be able to compile ImageDocument.o, we need to call std::round(), not just round(). BUG=none Committed: https://crrev.com/0a23e5ae7723975148d7f7f3d427f435445e0c21 Cr-Commit-Position: refs/heads/master@{#440950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
hugoh_UTC2
Hi Philip! Here is a small fixup that we need after https://codereview.chromium.org/2445413003 .
4 years ago (2016-12-02 09:56:39 UTC) #3
pdr.
On 2016/12/02 at 09:56:39, hugoh wrote: > Hi Philip! Here is a small fixup that ...
4 years ago (2016-12-02 21:51:53 UTC) #4
Mostyn Bramley-Moore
On 2016/12/02 21:51:53, pdr. wrote: > How often do we break you like this? If ...
4 years ago (2016-12-06 00:04:24 UTC) #5
pdr.
On 2016/12/06 at 00:04:24, mostynb wrote: > On 2016/12/02 21:51:53, pdr. wrote: > > How ...
4 years ago (2016-12-06 20:00:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548783002/1
3 years, 11 months ago (2016-12-29 09:29:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 10:38:13 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a23e5ae7723975148d7f7f3d427f435445e0c21
Cr-Commit-Position: refs/heads/master@{#440950}

Powered by Google App Engine
This is Rietveld 408576698