Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2548773002: Remove dead code with analyzer warning in test scripts (Closed)

Created:
4 years ago by Bill Hesse
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dead code with analyzer warning in test scripts BUG= Committed: https://github.com/dart-lang/sdk/commit/191184ba3daf04bb12f6fbddd1357a5d5d2dfc28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/testing/dart/runtime_configuration.dart View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
TBR=rmacnac@google.com
4 years ago (2016-12-02 09:39:29 UTC) #2
Bill Hesse
Committed patchset #1 (id:1) manually as 191184ba3daf04bb12f6fbddd1357a5d5d2dfc28 (presubmit successful).
4 years ago (2016-12-02 10:29:51 UTC) #4
rmacnak
4 years ago (2016-12-02 17:35:40 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698