Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/testing/dart/runtime_configuration.dart

Issue 2548773002: Remove dead code with analyzer warning in test scripts (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library runtime_configuration; 5 library runtime_configuration;
6 6
7 import 'dart:io' show Platform;
8
9 import 'compiler_configuration.dart' show CommandArtifact; 7 import 'compiler_configuration.dart' show CommandArtifact;
10 8
11 // TODO(ahe): Remove this import, we can precompute all the values required 9 // TODO(ahe): Remove this import, we can precompute all the values required
12 // from TestSuite once the refactoring is complete. 10 // from TestSuite once the refactoring is complete.
13 import 'test_suite.dart' show TestSuite; 11 import 'test_suite.dart' show TestSuite;
14 12
15 import 'test_runner.dart' show Command, CommandBuilder; 13 import 'test_runner.dart' show Command, CommandBuilder;
16 14
17 // TODO(ahe): I expect this class will become abstract very soon. 15 // TODO(ahe): I expect this class will become abstract very soon.
18 class RuntimeConfiguration { 16 class RuntimeConfiguration {
(...skipping 26 matching lines...) Expand all
45 43
46 case 'd8': 44 case 'd8':
47 return new D8RuntimeConfiguration(); 45 return new D8RuntimeConfiguration();
48 46
49 case 'none': 47 case 'none':
50 return new NoneRuntimeConfiguration(); 48 return new NoneRuntimeConfiguration();
51 49
52 case 'vm': 50 case 'vm':
53 return new StandaloneDartRuntimeConfiguration(); 51 return new StandaloneDartRuntimeConfiguration();
54 52
55 case 'dart_app':
56 return new DartAppRuntimeConfiguration(useBlobs: useBlobs);
57
58 case 'dart_precompiled': 53 case 'dart_precompiled':
59 if (configuration['system'] == 'android') { 54 if (configuration['system'] == 'android') {
60 return new DartPrecompiledAdbRuntimeConfiguration(useBlobs: useBlobs); 55 return new DartPrecompiledAdbRuntimeConfiguration(useBlobs: useBlobs);
61 } 56 }
62 return new DartPrecompiledRuntimeConfiguration(useBlobs: useBlobs); 57 return new DartPrecompiledRuntimeConfiguration(useBlobs: useBlobs);
63 58
64 case 'drt': 59 case 'drt':
65 return new DrtRuntimeConfiguration(); 60 return new DrtRuntimeConfiguration();
66 61
67 default: 62 default:
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration { 293 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
299 List<Command> computeRuntimeCommands( 294 List<Command> computeRuntimeCommands(
300 TestSuite suite, 295 TestSuite suite,
301 CommandBuilder commandBuilder, 296 CommandBuilder commandBuilder,
302 CommandArtifact artifact, 297 CommandArtifact artifact,
303 List<String> arguments, 298 List<String> arguments,
304 Map<String, String> environmentOverrides) { 299 Map<String, String> environmentOverrides) {
305 throw "Unimplemented runtime '$runtimeType'"; 300 throw "Unimplemented runtime '$runtimeType'";
306 } 301 }
307 } 302 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698