Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2548703002: cros: Smart unlock set-up had space for icon while none is show. (Closed)

Created:
4 years ago by sammiequon
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Smart unlock set-up had space for icon while none is show. Changed smart unlock icon show to only show if it user pod icon id is valid. Tested with smart unlock setup and smart unlock usage. R=xiyuan@chromium.org TEST=none BUG=652132 Committed: https://crrev.com/8f906fcba5e48b07fc1e27783b5341115aa50bbb Cr-Commit-Position: refs/heads/master@{#435984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/login/account_picker/user_pod_row.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sammiequon
xiyuan@ - Please take a look. Thanks!
4 years ago (2016-12-02 00:42:56 UTC) #2
xiyuan
lgtm
4 years ago (2016-12-02 18:11:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548703002/1
4 years ago (2016-12-02 18:49:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 19:04:13 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-02 19:06:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f906fcba5e48b07fc1e27783b5341115aa50bbb
Cr-Commit-Position: refs/heads/master@{#435984}

Powered by Google App Engine
This is Rietveld 408576698