ui/login/account_picker/user_pod_row.js - Issue 2548703002: cros: Smart unlock set-up had space for icon while none is show.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/login/account_picker/user_pod_row.js

Issue 2548703002: cros: Smart unlock set-up had space for icon while none is show. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/login/account_picker/user_pod_row.js

diff --git a/ui/login/account_picker/user_pod_row.js b/ui/login/account_picker/user_pod_row.js

index 71e88f292fade6756b7ce5bcca209238bf3dcd79..4d11b857d20a218cf39ee456f3dae7f5758632c5 100644

--- a/ui/login/account_picker/user_pod_row.js

+++ b/ui/login/account_picker/user_pod_row.js

@@ -374,7 +374,12 @@ cr.define('login', function() {

* Shows the icon.

show: function() {

- this.hidden = false;

+ // Show the icon if the current iconId is valid.

+ var validIcon = false;

+ UserPodCustomIcon.ICONS.forEach(function(icon) {

+ validIcon = validIcon || this.iconId_ == icon.id;

+ }, this);

+ this.hidden = validIcon ? false : true;

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »