Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 2548663002: [Devtools] Rename logEntries to node in network (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Rename logEntries to node in network This patch is in prepopration for groupping in network panel. Before we introduced logEntries as an interface, but this is proving to difficult to work with and complicating the code. We decided to move to use NetworkDataGridNode instead of an interface. This patch is just a rename. R=dgozman BUG=666971 Committed: https://crrev.com/2a92e8ab145d34cea6dfc94f9084e78e2724512a Cr-Commit-Position: refs/heads/master@{#435831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -93 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 4 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 4 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 17 chunks +54 lines, -55 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
allada
PTL
4 years ago (2016-12-01 21:57:27 UTC) #2
dgozman
lgtm. Thanks!
4 years ago (2016-12-02 01:34:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548663002/1
4 years ago (2016-12-02 02:35:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 02:40:27 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-02 02:41:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a92e8ab145d34cea6dfc94f9084e78e2724512a
Cr-Commit-Position: refs/heads/master@{#435831}

Powered by Google App Engine
This is Rietveld 408576698