Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2548663002: [Devtools] Rename logEntries to node in network (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index b7fd36d740eea84bf99ba9ae1a8edefd08afa1e9..94e5a12bd03adc9f4e0b3d4006fda86f79eb30c8 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -534,13 +534,12 @@ Network.NetworkLogView = class extends UI.VBox {
}
/**
- * @param {?Network.NetworkLogEntry} logEntry
+ * @param {?Network.NetworkDataGridNode} node
* @param {boolean} highlightInitiatorChain
*/
- setHoveredLogEntry(logEntry, highlightInitiatorChain) {
- // TODO(allada) Move this into LogEntry/NetworkDataGridNode.
- this._setHoveredNode(/** @type {?Network.NetworkDataGridNode} */ (logEntry), highlightInitiatorChain);
- this._highlightInitiatorChain((logEntry && highlightInitiatorChain) ? logEntry.request() : null);
+ setHoveredNode(node, highlightInitiatorChain) {
+ this._setHoveredNode(node, highlightInitiatorChain);
+ this._highlightInitiatorChain((node && highlightInitiatorChain) ? node.request() : null);
}
/**
@@ -553,7 +552,7 @@ Network.NetworkLogView = class extends UI.VBox {
this._hoveredNode = node;
if (this._hoveredNode)
this._hoveredNode.element().classList.add('hover');
- this._columns.setHoveredLogEntry(this._hoveredNode, !!highlightInitiatorChain);
+ this._columns.setHoveredNode(this._hoveredNode, !!highlightInitiatorChain);
}
/**

Powered by Google App Engine
This is Rietveld 408576698