[HttpJob] Record bytes read for requests

[HttpJob] Record bytes read for requests

This lets us see what request sizes look like over time and the percentage of bytes that come from the cache as opposed to the network.

BUG=669080
Committed: https://crrev.com/ded0021b702cda78f59fb92826f2ae51040e3d44
Cr-Commit-Position: refs/heads/master@{#436302}

[jkarlin, 2016-12-02 14:49:57]

jkarlin@chromium.org changed reviewers:
+ mmenke@chromium.org

[jkarlin, 2016-12-02 14:49:57]

mmenke@ PTAL, thanks!

[jkarlin, 2016-12-02 14:53:28]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 14:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-12-02 14:58:49]

LGTM

https://codereview.chromium.org/2548613003/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/2548613003/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job.cc:1508: if (request_->was_cached()) {
Can we just grab this from response_info_ instead?  I'd really like to reduce
the dependencies of URLRequestJob classes on the URLRequest, since the
URLRequest uses the URLRequestJob, not the other way around.

[jkarlin, 2016-12-02 15:04:07]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 15:04:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-12-02 15:06:22]

jkarlin@chromium.org changed reviewers:
+ rkaplow@chromium.org

[jkarlin, 2016-12-02 15:06:23]

Thanks mmenke, PTAL.

rkaplow@ PTAL at histograms.xml, thanks!

https://codereview.chromium.org/2548613003/diff/1/net/url_request/url_request...
File net/url_request/url_request_http_job.cc (right):

https://codereview.chromium.org/2548613003/diff/1/net/url_request/url_request...
net/url_request/url_request_http_job.cc:1508: if (request_->was_cached()) {
On 2016/12/02 14:58:49, mmenke wrote:
> Can we just grab this from response_info_ instead?  I'd really like to reduce
> the dependencies of URLRequestJob classes on the URLRequest, since the
> URLRequest uses the URLRequestJob, not the other way around.

Done.

[commit-bot: I haz the power, 2016-12-02 17:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:19:12]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-12-02 20:30:31]

lgtm

https://codereview.chromium.org/2548613003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2548613003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:31251: +<histogram
name="Net.HttpJob.PrefilterBytesRead" units="bytes">
does this need to be bytes, versus like kb for example? Just wondering since the
scale is so large

[jkarlin, 2016-12-05 15:00:25]

https://codereview.chromium.org/2548613003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2548613003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:31251: +<histogram
name="Net.HttpJob.PrefilterBytesRead" units="bytes">
On 2016/12/02 20:30:31, rkaplow wrote:
> does this need to be bytes, versus like kb for example? Just wondering since
the
> scale is so large

It's hard to say. I'd like more accuracy than 1KB. I'm assuming that the vast
majority of resources are less than 50MB. Will adjust and make a v2 metric if
necessary.

[jkarlin, 2016-12-05 15:02:11]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-12-05 15:02:12]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2548613003/#ps20001
(title: "Address comments from PS1")

[commit-bot: I haz the power, 2016-12-05 15:02:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 16:01:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480950131997180,
"parent_rev": "f3b3f5cca86b1394a98ac129c980c5a2cfd27fed", "commit_rev":
"75aaeeb1cec066ed76072fde42633e477148ab3e"}

[commit-bot: I haz the power, 2016-12-05 16:01:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 16:03:19]

Description was changed from

==========
[HttpJob] Record bytes read for requests

This lets us see what request sizes look like over time and the percentage of
bytes that come from the cache as opposed to the network.

BUG=669080
==========

to

==========
[HttpJob] Record bytes read for requests

This lets us see what request sizes look like over time and the percentage of
bytes that come from the cache as opposed to the network.

BUG=669080

Committed: https://crrev.com/ded0021b702cda78f59fb92826f2ae51040e3d44
Cr-Commit-Position: refs/heads/master@{#436302}
==========

[commit-bot: I haz the power, 2016-12-05 16:03:19]

Patchset 2 (id:??) landed as
https://crrev.com/ded0021b702cda78f59fb92826f2ae51040e3d44
Cr-Commit-Position: refs/heads/master@{#436302}