Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2548613003: [HttpJob] Record bytes read for requests (Closed)
Patch Set: Address comments from PS1 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 6934c78006ce18b4cebbc351cbadcdc51345e17d..afa90e22da74a176bdf69b9104fbd8fbe04fbce4 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -1484,12 +1484,25 @@ void URLRequestHttpJob::RecordPerfHistograms(CompletionCause reason) {
total_time);
}
}
+
+ UMA_HISTOGRAM_CUSTOM_COUNTS("Net.HttpJob.PrefilterBytesRead",
+ prefilter_bytes_read(), 1, 50000000, 50);
if (response_info_->was_cached) {
UMA_HISTOGRAM_TIMES("Net.HttpJob.TotalTimeCached", total_time);
+ UMA_HISTOGRAM_CUSTOM_COUNTS("Net.HttpJob.PrefilterBytesRead.Cache",
+ prefilter_bytes_read(), 1, 50000000, 50);
+
if (response_info_->unused_since_prefetch)
UMA_HISTOGRAM_COUNTS("Net.Prefetch.HitBytes", prefilter_bytes_read());
} else {
UMA_HISTOGRAM_TIMES("Net.HttpJob.TotalTimeNotCached", total_time);
+ UMA_HISTOGRAM_CUSTOM_COUNTS("Net.HttpJob.PrefilterBytesRead.Net",
+ prefilter_bytes_read(), 1, 50000000, 50);
+
+ if (request_info_.load_flags & LOAD_PREFETCH) {
+ UMA_HISTOGRAM_COUNTS("Net.Prefetch.PrefilterBytesReadFromNetwork",
+ prefilter_bytes_read());
+ }
if (is_https_google) {
if (used_quic) {
UMA_HISTOGRAM_MEDIUM_TIMES(
@@ -1502,10 +1515,6 @@ void URLRequestHttpJob::RecordPerfHistograms(CompletionCause reason) {
}
}
- if (request_info_.load_flags & LOAD_PREFETCH && !request_->was_cached())
- UMA_HISTOGRAM_COUNTS("Net.Prefetch.PrefilterBytesReadFromNetwork",
- prefilter_bytes_read());
-
start_time_ = base::TimeTicks();
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698