services/ui/public/cpp/tests/window_server_test_base.cc - Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/tests/window_server_test_base.cc

Issue 2548513002: Update bool WindowManager::OnWmSetBounds() to match with its desirable behavior. (Closed)

Patch Set: Remove if condition statetment in Window::SetBounds(const gfx::Rect& new_bounds). Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/public/cpp/tests/window_server_test_base.cc

diff --git a/services/ui/public/cpp/tests/window_server_test_base.cc b/services/ui/public/cpp/tests/window_server_test_base.cc

index 55f5e9d2120664a68185aa25187b56ed101d2bfa..25c2355f88bab3bc926d2f5bd72f53fa29b7912b 100644

--- a/services/ui/public/cpp/tests/window_server_test_base.cc

+++ b/services/ui/public/cpp/tests/window_server_test_base.cc

@@ -118,11 +118,8 @@ void WindowServerTestBase::SetWindowManagerClient(WindowManagerClient* client) {

window_manager_client_ = client;

}

-bool WindowServerTestBase::OnWmSetBounds(Window* window, gfx::Rect* bounds) {

- return window_manager_delegate_

- ? window_manager_delegate_->OnWmSetBounds(window, bounds)

- : true;

+void WindowServerTestBase::OnWmSetBounds(Window* window,

+ const gfx::Rect& bounds) {}

bool WindowServerTestBase::OnWmSetProperty(

Window* window,